Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor release: Showing off #2348

Merged
merged 40 commits into from
Feb 1, 2019
Merged

Conversation

freimair
Copy link
Member

@freimair freimair commented Jan 31, 2019

see bisq-network/proposals#62 for details

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In P2PNetworkLoad.java:

Why not use
buckets.putIfAbsent(className, new Counter()); buckets.get(className).increment();

instead of
try { buckets.get(className).increment(); } catch (NullPointerException nullPointerException) { buckets.put(className, new Counter()); }

@ManfredKarrer
Copy link
Member

In P2PNetworkLoad.java:
Re:
bucketsPerHost.put(connection.peersNodeAddressProperty().getValue(), buckets);
It can be that connection.peersNodeAddressProperty() is not set yet. Maybe more safe if you add a check if it is nul null.

Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 159a5e5 into bisq-network:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants