-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor release: Showing off #2348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In P2PNetworkLoad.java:
Why not use
buckets.putIfAbsent(className, new Counter()); buckets.get(className).increment();
instead of
try { buckets.get(className).increment(); } catch (NullPointerException nullPointerException) { buckets.put(className, new Counter()); }
In P2PNetworkLoad.java: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
see bisq-network/proposals#62 for details