Allow tor to be used with regtest #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a tor .onion address to be specified as the bitcoinRegtestHost parameter and, as long as the --useTorForBtc=true parameter is included, it will use tor when on regtest.
The logged message that indicates the number of btc nodes to connect to was incorrect when only a single node is used in regtest mode.
|
@devinbileck In case you have not seen my comments, could you have a look? |
|
@ManfredKarrer I dont see any comments within this PR. |
ManfredKarrer
suggested changes
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simulate a realistic environment for testing purposes, this will allow tor to be used with regtest. Use the bitcoinRegtestHost parameter and specify a tor .onion address as well as include the --useTorForBtc=true parameter.