Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow host as bitcoinRegtestHost parameter #2312

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

devinbileck
Copy link
Member

When using a remote regtest host, instead of having to pass
REG_TEST_SERVER to the bitcoinRegtestHost parameter and hard code the
host address within the code, allow the host to be specified by the
bitcoinRegtestHost parameter.

When using a remote regtest host, instead of having to pass
REG_TEST_SERVER to the bitcoinRegtestHost parameter and hard code the
host address within the code, allow the host to be specified by the
bitcoinRegtestHost parameter.
@ManfredKarrer
Copy link
Contributor

@devinbileck Can you merge in master? There have been some issue with a test class

@devinbileck
Copy link
Member Author

@ManfredKarrer Done!

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - But as I haven't touched part of this code yet, I'll leave it to @ManfredKarrer to merge.

Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 92d15c2 into bisq-network:master Jan 24, 2019
@devinbileck devinbileck deleted the regtest-host-parameter branch January 24, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants