Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JAVA_HOME override #2248

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Improve JAVA_HOME override #2248

merged 1 commit into from
Jan 14, 2019

Conversation

devinbileck
Copy link
Member

Check to see if javapackager exists prior to overriding JAVA_HOME
in package scripts.

@devinbileck
Improve JAVA_HOME override
cad6b61 
Check to see if javapackager exists prior to overriding JAVA_HOME
in package scripts.
ripcurlx
ripcurlx approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - looking good

@ripcurlx ripcurlx merged commit bfda268 into bisq-network:master Jan 14, 2019
@devinbileck devinbileck deleted the improve-JAVA_HOME-override branch January 14, 2019 17:11
@ripcurlx ripcurlx mentioned this pull request Jan 30, 2019
Closed
@devinbileck devinbileck mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@ManfredKarrer ManfredKarrer Awaiting requested review from ManfredKarrer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinbileck @ripcurlx