Bisq Network Monitor: Babysteps #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeams
suggested changes
Dec 28, 2018
monitor/src/test/java/bisq/monitor/TorHiddenServiceStartupTimeTests.java
Outdated
Show resolved
Hide resolved
monitor/src/test/java/bisq/monitor/TorHiddenServiceStartupTimeTests.java
Outdated
Show resolved
Hide resolved
|
Will review once back from holiday in January. |
|
Is bisq.monitor.metric.Dummy.java still needed (not used yet)? |
- Apply reorg imports and reformat to test classes
- Add /monitor/TorHiddenServiceStartupTimeTests/* and /monitor/monitor-tor/*
- Fix spelling - Remove exception throw clause which was never thrown - Add not null preconditions - Remove unneeded types in diamonds - Add final - Fix java doc - Make Reporter constructor protected (abstract)
$logbackVersion causes build errors.
- Revert spelling error as misspelling was used for test - Add TODO for failing test (timing issue, seems to fail just sometimes) - Set @disable to test classes which take longer as Tor is started
…to ManfredKarrer-monitor-nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babysteps release of the Bisq Network Monitor proposed here