Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Spend pending BSQ #2171

Closed
wants to merge 5 commits into from
Closed

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented Dec 25, 2018

Introduces parsing of unconfirmed transactions to allow for spending of pending BSQ transactions.

I'm not really clear how the UI should handle the pending amounts, but the accounting needs an overhaul anyway so I plan to do that in a different PR.

Also fixes some other issues found along the way while testing.

Fixes #2107

All pending txs are parsed by the TxParser but kept in UnconfirmedState.
The confirmed state and unconfirmed state are aggregated on demand when
getUnspentTxOutputMap is called.
@ManfredKarrer ManfredKarrer removed the request for review from ripcurlx December 29, 2018 09:00
@ManfredKarrer ManfredKarrer self-assigned this Jan 1, 2019
@ripcurlx ripcurlx added the in:dao label Jan 7, 2019
@sqrrm sqrrm changed the title Spend pending BSQ [WIP] Spend pending BSQ Jan 10, 2019
@sqrrm
Copy link
Member Author

sqrrm commented Jan 10, 2019

I'm splitting this into separate PRs to not mix features in one PR

@ManfredKarrer
Copy link
Member

@sqrrm Should we close that one then?

@sqrrm
Copy link
Member Author

sqrrm commented Jan 10, 2019

@ManfredKarrer I will close it when I've split the commits.

@sqrrm
Copy link
Member Author

sqrrm commented Jan 11, 2019

Split this into #2242 and #2244

@sqrrm sqrrm closed this Jan 11, 2019
@sqrrm sqrrm deleted the spend-pending-bsq branch September 19, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants