Update windows install experience #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase the minimum supported OS version to Windows 7 with SP1. Previously it was Windows XP which has been EOL for some time now. Hopefully no one is still using Windows XP. - Show a final dialog once the install has completed. This will inform the user that the install has completed with an option to launch the application. Previously it would skip this final dialog and immediately launch the application, but the user may not want to launch it immediately. - Create an application shortcut on the user's desktop. - Check if the application is running prior to install or uninstall and abort with a prompt to the user that the application must first be closed. - German, French, and Spanish translations. The installer should auto-detect the OS language and display all text in the appropriate language. For now I have just added a couple languages, but it is very easy to add any of the other languages supported by Inno Setup. - Additionally, I removed a few unnecessary items that weren't being utilized such as installing a service.
ripcurlx
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the minimum supported OS version to Windows 7 with SP1.
Previously it was Windows XP which has been EOL for some time now.
Hopefully no one is still using Windows XP.
Show a final dialog once the install has completed. This will inform
the user that the install has completed with an option to launch the
application. Previously it would skip this final dialog and immediately
launch the application, but the user may not want to launch it
immediately.
Create an application shortcut on the user's desktop.
Check if the application is running prior to install or uninstall and
abort with a prompt to the user that the application must first be
closed.
German, French, and Spanish translations. The installer should
auto-detect the OS language and display all text in the appropriate
language. For now I have just added a couple languages, but it is very
easy to add any of the other languages supported by Inno Setup.
Additionally, I removed a few unnecessary items that weren't being
utilized such as installing a service.