Take offer refactoring #2080
Closed
Take offer refactoring #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts Feature/payment accounts
…lds-to-offer-details Additional fields for OfferDetails
…lds-for-trade Additional fields for TradeDetails.
… CORS to allow connections from any domain
…-deposit Allow user to pass buyerSecurityDeposit when creating an offer.
…sts-for-withdraw-funds-from-trade Tests for /trade/{id}/move-funds-to-bisq-wallet endpoint
…-related-endpoints Feature/wallet address related endpoints
…reated-address Feature/more info on created address
…btc-address Feature/refactor post btc address
Merge latest changes on master into http-api branch
Fix tests of http-api
Tune Dockerfile
…ature Experimental feature
Remove backups from volume before running tests
Attempt to write TradeManager.onTakeOffer test.
Create offer manually instead of using mock
Assert error property is not set on the trade
Some validations
blabno
requested review from
cbeams,
ManfredKarrer and
ripcurlx
as code owners
|
Close as discussed by phone. Will wait for a PR for core and desktop only code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.