List Bitmark (BTM) #2078
List Bitmark (BTM) #2078
Conversation
|
@piratelinux commits need to be squashed into single commit. |
|
Ya I was just thinking of that. I will do now. |
piratelinux
force-pushed
the
list-bitmark
branch
from
108e90d to
bd9198a
Compare
piratelinux
requested review from
cbeams,
ManfredKarrer and
ripcurlx
as code owners
piratelinux
force-pushed
the
list-bitmark
branch
3 times, most recently
from
e7bbe88 to
51867e9
Compare
There was a problem hiding this comment.
@piratelinux Don't request a review if your branch still has conflicts.
use latest validator class
piratelinux
force-pushed
the
list-bitmark
branch
from
ff2efb9 to
f1d1398
Compare
|
I think the squashing worked now? I don't remember requesting review. Sorry. |
ManfredKarrer
requested review from
cbeams
and removed request for
cbeams and
ManfredKarrer
|
Just checking...Are you waiting for me? Because I think I already did the request changes, so when will this be reviewed? Thanks |
|
How do I search for specific transaction? |
|
Bisq codestyle? This explorer can be used to look up a transaction: https://chainz.cryptoid.info/btm/ Is that fine or should we modify our explorer on explorer.bitmark.co? |
|
Yes, Bisq has it's own code style. It's defined here https://github.com/bisq-network/bisq/tree/master/.idea/codeStyles I do not care about the url structure of the explorer. I don't see any search input where I could type the transaction id. |
|
Hi, for the explorer, I made some changes on a "dev" page: http://explorer.bitmark.co/index-dev.php. I am waiting for approval from someone, but it should soon be on explorer.bitmark.co. It allows for searching of txids, block hashes, or block numbers, and for txids it show the full block info (all transactions and amounts getting sent to the outputs). If you need more detailed transaction info (such as list of all inputs and values) then I can add that too. For the code style, I looked through it and saw some properties like BLANK_LINES_BEFORE_PACKAGE and SOFT_MARGINS. But I think it satisfies it. I compared with other pull requests that were merged, and perhaps one problem is that I'm using tabs (automatic with emacs) in one place instead of spaces for indentation: https://github.com/bisq-network/bisq/pull/2078/files#diff-a500a9d38e9f89cca4fa053aab070da6R27. Is that the only issue? |
|
Please use IntelliJ Idea which has free community edition available and format the code according to provided code style. We are not going to tell to what needs to be fixed on each line. As to explorer you have to explain how arbitrators can verify if transaction has taken place or not between two given addresses. |
|
So I tried IntelliJ, imported the main directory, imported the Project.xml code style. I see some errors/warnings but not sure if it's related to code style. Any more hints would be useful since this is quite tedious for small details... For the explorer, sure I can add more details about the input addresses, to make sure you can identify the sending address(es). |
|
Thanks, finally! I updated the explorer by the way: http://explorer.bitmark.co |
Official project URL: http://bitmark.io
Official block explorer URL: http://explorer.bitmark.co
Sorry for the 3rd attempt! I am on the move and keep forgetting. I am telling the other developers to remind me this time.
I will rely on the automated tests to see if it builds because I don't have Java 10 on my system.