Fix broken startScripts in $destinationDir/bin dirs #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK - I'll leave it to @cbeams to ACK and merge. |
Prior to this fix, the build failed with the following error:
FAILURE: Build failed with an exception.
* Where:
Build file '/Users/cbeams/Work/bisq-network/bisq/build.gradle' line: 109
* What went wrong:
Execution failed for task ':desktop:installDist'.
> No such property: bat for class: java.lang.String
cbeams
added a commit
that referenced
this pull request
Nov 27, 2018
Fix broken startScripts in $destinationDir/bin dirs
|
hm. I did not get this error when I tested fix locally. And Travis did not complain either. regarding lisp case: old habits. I will try :) |
This was referenced Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in the build procedure produces broken startScripts in the respective
$destinationDir/bin-directories.Issue
startScripts located in
$destinationDir/bin-directories yieldwhen executed.
Cause
The startScripts get changed in order to be executed in the project root directory. However, they get changed before they are copied and thus, the original startScripts (still located in the
$destinationDir/bin-directories) have a wrong path prefix for the classpath declaration (i.e..../bin/lib/...instead of.../bin/../lib/...)Fix
First copy the startScripts to
rootProject.projectDirand only then change them.Notes