[WIP] Fixed netlayer and tor binary dependency issues #1914
Conversation
|
please do not merge this pull-request. I will supply a clean one if everything works again. just using the travis CI here |
ManfredKarrer
changed the title
|
Thanks for looking into it! |
There was a problem hiding this comment.
NACK per comments. Minor stuff, but the Maven Central change is more than just a nit and should actually be changed. Also, please review rules 3 and 5 from the commit comment guidelines at bisq-network/style#9 (no need to rebase/reword the commits in this PR, just for future reference). Thanks.
build.gradle
Outdated
| @@ -37,9 +37,9 @@ configure(subprojects) { | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenCentral() | |||
There was a problem hiding this comment.
Please don't change this. There are issues with JCenter's SSL cert under OpenJDK 10, that's why I recently switched everything to Maven Central.
| @@ -37,9 +37,9 @@ configure(subprojects) { | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenCentral() | |||
| maven { url 'https://jitpack.io' } | |||
| maven { url 'https://raw.githubusercontent.com/JesusMcCloud/tor-binary/master/release/' } | |||
There was a problem hiding this comment.
Please don't kill the whitespace after the opening brace.
|
Sorry, @freimair, I just noticed this is still WIP and that you said you'd clean it up once you know everything is working. |
|
working again. I am going to close this mess and open a clean one. |
netlayer had and has a well-hidden build configuration issue since version 0.4.2. It always fetches the "master" binaries instead of the binaries of the respective release. although until recently, bisq wanted to use 0.4.2, but actually has used 0.4.7 already. Due to changes in netlayer and its upcoming release, the netlayer build configuration has changed and thus, the issue showed itself.
This is an attempt to fix the issue temporarily. I, however, do expect failures due to checksum mismatches. Work in progress.
If this works, I will amend to the request and make things more final, i.e. create a proper release of netlayer and include that.