Dao UI improvements #1795
Merged
Dao UI improvements #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change FULL_DAO_NODE option from boolean to string to be able to detect not set values - isFullDaoNode, rpcUser and rpcPw can be set in the UI. If prog ars are available they will overwrite the UI data.
sqrrm
reviewed
Oct 23, 2018
| case PROPOSAL: | ||
| break; | ||
| case BREAK1: | ||
| firstBlock++; |
There was a problem hiding this comment.
This seems like the opposite of what the comment says. This will show the second block of the break as the first block.
There was a problem hiding this comment.
Yes, should rename the var or refactor it so its less hacky...
...rc/main/java/bisq/core/dao/governance/proposal/compensation/CompensationProposalService.java
Outdated
Show resolved
Hide resolved
| // block of the technical 3601 blocks is displayed as part of the break1 phase. | ||
| /* PHASE_UNDEFINED(0), | ||
| PHASE_PROPOSAL(3601), // 24 days | ||
| PHASE_BREAK1(149), // 1 day |
ripcurlx
suggested changes
Oct 23, 2018
| return firstBlock; | ||
| } | ||
|
|
||
| // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the |
...rc/main/java/bisq/core/dao/governance/proposal/compensation/CompensationProposalService.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsListItem.java
Outdated
Show resolved
Hide resolved
| isDaoFullNodeCheckBox.setOnAction(e -> { | ||
| String key = "daoFullModeInfoShown"; | ||
| if (isDaoFullNodeCheckBox.isSelected() && preferences.showAgain(key)) { | ||
| String url = "https://bisq.network/docs/dao-full-node"; |
There was a problem hiding this comment.
Maybe we could think about moving all URLs into one place so they get easier to maintain when the structure in the docs is changed.
There was a problem hiding this comment.
Yes good idea. I use forwarders so we are independent from real url.
|
@ManfredKarrer Also please merge master into the PR so the travis build can run. |
@Christoph Can you have a look why JMockit is not working anymore in that module? TradesChartsViewModel is null and creates a nullpointer. Adding RunWith("JMockit") as it was earlier does not work with changed gradle file with newer JMockit version.
This was referenced Oct 30, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too much small changed to list all....