Java 10 support #1660

ripcurlx · 2018-09-07T12:14:31Z

I've started to adapt the current mono repository to support Java 10.
The current state of this branch is, that gradle build runs and you can launch the app from IDEA.
Still there are a couple of things left, where help is wanted (see check list)

Upgrade JavaFX code
Implement alternative for progress indicator (block chain confirmations) as current implementation won't work for java 10
Update lombok
Update source compatibility settings
Update travis setting
Implement power mock support
Implement JMockit support
Merge with master (and update everything new to Java 10)
Solve issue with library that includes Java 9 module configuration

Release Build

Java strong cyphers supported by default in Java 10
Configure or replace BouncyCastle provide (Removed Extension Mechanism)

ripcurlx · 2018-09-07T12:31:38Z

@initCCG: With Java 10, Thai now renders fine! 😄

ripcurlx · 2018-09-11T16:33:47Z

@cbeam I don't know why the release build worked for me when I tested the mono repo branch, but now while testing my Java 10 build I saw that running gradle build within the desktop directory fails with following error:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'bisq-desktop'.
> Could not resolve all dependencies for configuration ':compile'.
   > Could not resolve project :p2p.
     Required by:
         project :
      > Project : declares a dependency from configuration 'compile' to configuration 'default' which is not declared in the descriptor for project :p2p.
   > Could not resolve project :core.
     Required by:
         project :
      > Project : declares a dependency from configuration 'compile' to configuration 'default' which is not declared in the descriptor for project :core.
   > Could not resolve project :common.
     Required by:
         project :
      > Project : declares a dependency from configuration 'compile' to configuration 'default' which is not declared in the descriptor for project :common.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
See https://docs.gradle.org/4.6/userguide/command_line_interface.html#sec:command_line_warnings

I guess it is something obvious if you know how to gradle 😉 - Do you know what I have to configure differently in the build.gradle file of desktop?

cbeams · 2018-09-11T16:45:36Z

@ripcurlx, it's not something I've seen before, and I don't have time now to install JDK 10 and investigate personally. I found this: https://stackoverflow.com/questions/42929841/app-declares-a-dependency-from-configuration-compile-to-configuration-default#44457269, but it doesn't provide much insight to me on first read.

I would just start winding back commits (you only have half a dozen or so on that branch) and see where the trouble crept in. Let me know and when I have time later (i.e. tomorrow), I can take a look. Would like to get JDK 10 installed anyway.

ripcurlx · 2018-09-11T16:51:13Z

@cbeams The problem is that I see now the same problem in master with Java 8 as well. I don't know why it worked for me before. Still gradle build works in the root, but not within the desktop sub directory.

cbeams · 2018-09-11T16:54:14Z

Confirmed. Same here. This is one of those "improvements we can make after the merge" that I mentioned. I'll patch it up soon. In the meantime, you can run gradle :desktop:build from the root to isolate bisq-desktop. Work for you in the meantime?

ripcurlx · 2018-09-11T17:03:45Z

@cbeams Seems to work - thanks! Added a temporary workaround in create_app.sh for now.

ripcurlx · 2018-09-12T10:44:55Z

@cbeams @ManfredKarrer The good thing with Java 10 is that it supports strong cyphers by default, so there is one workaround less. The bad thing is, that they dropped the extension mechanism, we used for BouncyCastle (https://docs.oracle.com/javase/10/migrate/toc.htm#JSMIG-GUID-2C896CA8-927C-4381-A737-B1D81D964B7B). Unfortunately I haven't figured it out how to include the BC jar otherwise in our release build. Any ideas are highly appreciated :-)

cbeams · 2018-09-12T12:25:31Z

I liked into this for a few mins when you first sent it, searching, checking BC issue tracker, etc, and didn’t see anything (surprisingly, given this change was actually made in jdk 9). Will be busy for a while now but will try to look again later today.

…

On Sep 12, 2018, at 12:44 PM, Christoph Atteneder ***@***.***> wrote: @cbeams @ManfredKarrer The good thing with Java 10 is that it supports strong cyphers by default, so there is one workaround less. The bad thing is, that they dropped the extension mechanism, we used for BouncyCastle (https://docs.oracle.com/javase/10/migrate/toc.htm#JSMIG-GUID-2C896CA8-927C-4381-A737-B1D81D964B7B). Unfortunately I haven't figured it out how to include the BC jar otherwise in our release build. Any ideas are highly appreciated :-) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ManfredKarrer · 2018-09-12T23:32:55Z

@ripcurlx I sent an email to @freimair. Maybe we should just drop BC. Too many problems all the time with it...

ripcurlx · 2018-09-13T08:50:22Z

@ManfredKarrer Thanks! If the BC issue is solved this branch is ready for merge.

…va10-support

…iguration of fontawesomefx library

cbeams

utACK. I'd like to properly test it locally against JDK 10 locally, but I still don't have it installed and want to get back about this quickly.

Nit: it would be good to extract the often-duplicated value assigned to @PowerMockIgnore annotations into a static String[] somewhere with a comment as to why it's necessary.

I wouldn't merge this without at least a couple proper ACKs, ideally across OSes. Again, just wanted to report I've looked through this and don't see anything obviously wrong.

ManfredKarrer · 2018-09-18T15:17:16Z

I will test it soon.
@blabno @mrosseel Could you give it a test as well an ACk if ok for you?

ManfredKarrer · 2018-09-18T16:28:40Z

@ripcurlx
I get that warning:
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/Users/dev/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/4.1.0/eeb69005da379a10071aa4948c48d89250febb07/guice-4.1.0.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Maybe we need to update Guice?

ManfredKarrer · 2018-09-18T16:35:05Z

Just tried Guice v 4.2 but same warning.

ManfredKarrer · 2018-09-18T16:45:58Z

Seems it is a groovy issue (used in Gradle):
gradle/gradle#2995 (comment)

ManfredKarrer · 2018-09-18T17:03:33Z

@ripcurlx
There was a bug with SetupUtils (preventing seed nodes to start up).
UserThread.execute(resultHandler::handleResult); was removed in an earlier commit.

Should be:

Thread checkCryptoThread = new Thread() {
            @Override
            public void run() {
                try {
                    Thread.currentThread().setName("checkCryptoThread");
                    log.trace("Run crypto test");
                    // just use any simple dummy msg
                    Ping payload = new Ping(1, 1);
                    SealedAndSigned sealedAndSigned = EncryptionService.encryptHybridWithSignature(payload,
                            keyRing.getSignatureKeyPair(), keyRing.getPubKeyRing().getEncryptionPubKey());
                    DecryptedDataTuple tuple = encryptionService.decryptHybridWithSignature(sealedAndSigned,
                            keyRing.getEncryptionKeyPair().getPrivate());
                    if (tuple.getNetworkEnvelope() instanceof Ping &&
                            ((Ping) tuple.getNetworkEnvelope()).getNonce() == payload.getNonce() &&
                            ((Ping) tuple.getNetworkEnvelope()).getLastRoundTripTime() == payload.getLastRoundTripTime()) {
                        log.debug("Crypto test succeeded");

                        UserThread.execute(resultHandler::handleResult);
                    } else {
                        errorHandler.accept(new CryptoException("Payload not correct after decryption"));
                    }
                } catch (CryptoException | ProtobufferException e) {
                    log.error(e.toString());
                    e.printStackTrace();
                    errorHandler.accept(e);
                }
            }
        };
        checkCryptoThread.start();
    }

Beside that all works for me. So as soon that is fixed I can give a ACK.

Here is a patch:

===================================================================
--- core/src/main/java/bisq/core/app/SetupUtils.java	(date 1537286276000)
+++ core/src/main/java/bisq/core/app/SetupUtils.java	(date 1537289718000)
@@ -65,6 +65,8 @@
                             ((Ping) tuple.getNetworkEnvelope()).getNonce() == payload.getNonce() &&
                             ((Ping) tuple.getNetworkEnvelope()).getLastRoundTripTime() == payload.getLastRoundTripTime()) {
                         log.debug("Crypto test succeeded");
+
+                        UserThread.execute(resultHandler::handleResult);
                     } else {
                         errorHandler.accept(new CryptoException("Payload not correct after decryption"));
                     }

ManfredKarrer · 2018-09-18T17:22:25Z

@ripcurlx
The removal of the StaticProgressIndicatorBehavior.java and StaticProgressIndicatorSkin.java at #1660 re-introduce the performance problems of the ProgressIndicator.
CPU usage with spinning ProgressIndicator is about 15%, without it its about 10% (run in IDE debug mode, standalone would be lower in total but difference would be the same).
Maybe we remove the ProgressIndicator completely or we re-apply the fixes. We can still merge the PR from that but I think we should fix that before the next release.

ManfredKarrer · 2018-09-18T17:12:38Z

desktop/src/main/java/bisq/desktop/util/CurrencyList.java

    public void updateWithCurrencies(List<TradeCurrency> currencies, @Nullable CurrencyListItem first) {
        List<CurrencyListItem> result = Lists.newLinkedList();
        Optional.ofNullable(first).ifPresent(result::add);
        result.addAll(getPartitionedSortedItems(currencies));
-        setAll(result);
+        delegate.addAll(result);


To have the same behaviour as before (setAll) we should add a clear() before the addAll.

ManfredKarrer · 2018-09-18T17:32:33Z

Here another nit patch:

Index: core/src/test/java/bisq/core/crypto/SigTest.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- core/src/test/java/bisq/core/crypto/SigTest.java	(date 1537286276000)
+++ core/src/test/java/bisq/core/crypto/SigTest.java	(date 1537291722000)
@@ -23,13 +23,6 @@
 import bisq.common.crypto.Sig;
 import bisq.common.storage.FileUtil;
 
-import org.bouncycastle.jce.provider.BouncyCastleProvider;
-
-import java.security.KeyStoreException;
-import java.security.NoSuchAlgorithmException;
-import java.security.Security;
-import java.security.cert.CertificateException;
-
 import java.io.File;
 import java.io.IOException;
 
@@ -50,7 +43,7 @@
     private File dir;
 
     @Before
-    public void setup() throws CertificateException, NoSuchAlgorithmException, KeyStoreException, IOException, CryptoException {
+    public void setup() throws IOException {
 
         dir = File.createTempFile("temp_tests", "");
         //noinspection ResultOfMethodCallIgnored

ManfredKarrer · 2018-09-18T17:40:30Z

I did some smoke tests between old version and java 10 version and all worked.

ripcurlx · 2018-09-18T18:55:26Z

@ManfredKarrer I applied your suggestions, but I have a question regarding the Status Indicator. Actually besides extending a different base class the only thing I need to change was in the constructor to replace

if (spinner != null) {
                if (!(getSkinnable().impl_isTreeVisible() && getSkinnable().getScene() != null)) {
                    getChildren().remove(spinner);
                    spinner = null;
                    timeLineNulled = true;
                }
            }

with

if (spinner != null) {
                if (getSkinnable().getScene() != null) {
                    getChildren().remove(spinner);
                    spinner = null;
                    timeLineNulled = true;
                }
            }

as getSkinnable().impl_isTreeVisible() isn't accessible anymore. Do you remember if that was the root cause of the performance issue? So I know where to look for a workaround for this missing check.

ripcurlx · 2018-09-18T19:13:58Z

@cbeams As I'm only able to replace primitives in annotations the best I could do would be something like:

package bisq.core.util;

public class PowerMockUtil {
    // Workaround for PowerMock with Java 9+. For more details see https://github.com/powermock/powermock/issues/864
    public static final String ignoreXerces = "com.sun.org.apache.xerces.*";
    public static final String ignoreJavaxXML = "javax.xml.*";
    public static final String ignoreOrgXML = "org.xml.*";
}

and use it like that:
@PowerMockIgnore({PowerMockUtil.ignoreXerces, PowerMockUtil.ignoreJavaxXML, PowerMockUtil.ignoreOrgXML})
Not sure if that improves it a lot.

ManfredKarrer · 2018-09-18T19:17:09Z

@ripcurlx I added a new issue here #1692

ManfredKarrer · 2018-09-18T19:19:33Z

@ripcurlx From my side that PR can be merged. Not sure if you want to wait for more reviewers. I just got build problems with the current master, so maybe its better to get that merged soon, to get those setup changes completed?

ripcurlx · 2018-09-18T19:24:35Z

@ManfredKarrer I only tried it on macOS High Sierra (10.13+) with Java 10.0.1 and macOS El Capitan (10.11+) with Java 10.0.2. With what configuration did you run the test?

ManfredKarrer · 2018-09-18T19:31:08Z

I tested with 10.12.6 (Sierra) and java 10.0.2.

ripcurlx · 2018-09-18T20:11:57Z

Also tested now on Ubuntu 16.0.4 with Java 10.0.2

ManfredKarrer · 2018-09-18T21:53:48Z

ACK to the latest changes db17991

ManfredKarrer · 2018-09-18T21:54:52Z

As discussed with @ripcurlx I will merge now. He tested also successfully on the VMs.

ripcurlx added 8 commits September 5, 2018 18:45

Clean up errors for testing

9b4b062

Remove files that use classes that can't be accessed anymore

4725191

Update lombok library

73e4ee5

Update source compatibility to Java 10

bd9a208

Update travis Java version

5d23971

Make power mock tests Java 10 compatibile

e319449

Add not working JMockit setup (help wanted)

8ed7f42

Use FXCollections instead of not existing ObservableListWrapper

13266b2

Change progress indicator skin to work with Java 9+

dd6a372

Add temporary workaround for running desktop build

2efe20a

Add -srcdir for Java 10 javapackager

672e362

ripcurlx mentioned this pull request Sep 12, 2018

Arch AUR package install error #1677

Closed

Fix JMockit setup

64370f7

ripcurlx added 6 commits September 14, 2018 15:28

Update fontawesome library

1c783e4

Use default security provider instead of Bouncy Castle

4c068af

Merge branch 'master' into java10-support

40eadcc

Merge branch 'master' of github.com:bisq-network/bisq-desktop into ja…

28c96d6

…va10-support

Add Java 10 configuration for merged repositories

68fb116

Add workaround to prevent javapackager to fail because of module conf…

a8dd11c

…iguration of fontawesomefx library

ripcurlx changed the title ~~[WIP] Java 10 support~~ Java 10 support Sep 18, 2018

cbeams approved these changes Sep 18, 2018

View reviewed changes

ManfredKarrer suggested changes Sep 18, 2018

View reviewed changes

ripcurlx added 3 commits September 18, 2018 20:29

Add missing result handler execution

f7e4e5a

Clear list before setting all currencies

0643357

Remove not thrown exceptions

db17991

ManfredKarrer mentioned this pull request Sep 18, 2018

Fix performance issues with Java 10 version of ProgressIndicator #1692

Closed

ManfredKarrer merged commit a6fe389 into bisq-network:master Sep 18, 2018

cbeams mentioned this pull request Sep 19, 2018

Fix gradle build files, update docs #1696

Merged

This was referenced Sep 19, 2018

Check if Java9 is already ready for use #1057

Closed

A part of the build instructions won't work with Java >= 1.9 #813

Closed

java.util.NoSuchElementException raised when switching between "Sell BTC" and "Buy BTC" tabs #995

Closed

ripcurlx mentioned this pull request Nov 30, 2018

For November 2018 bisq-network/compensation#177

Closed

ripcurlx deleted the java10-support branch December 18, 2019 08:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java 10 support #1660

Java 10 support #1660

ripcurlx commented Sep 7, 2018 •

edited

Loading

ripcurlx commented Sep 7, 2018

ripcurlx commented Sep 11, 2018

cbeams commented Sep 11, 2018

ripcurlx commented Sep 11, 2018

cbeams commented Sep 11, 2018

ripcurlx commented Sep 11, 2018

ripcurlx commented Sep 12, 2018

cbeams commented Sep 12, 2018 via email

ManfredKarrer commented Sep 12, 2018

ripcurlx commented Sep 13, 2018

cbeams left a comment

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018 •

edited

Loading

ManfredKarrer commented Sep 18, 2018

ManfredKarrer Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ripcurlx commented Sep 18, 2018

ripcurlx commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018 •

edited

Loading

ManfredKarrer commented Sep 18, 2018

ripcurlx commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018 •

edited

Loading

ripcurlx commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

Java 10 support #1660

Java 10 support #1660

Conversation

ripcurlx commented Sep 7, 2018 • edited Loading

Release Build

ripcurlx commented Sep 7, 2018

ripcurlx commented Sep 11, 2018

cbeams commented Sep 11, 2018

ripcurlx commented Sep 11, 2018

cbeams commented Sep 11, 2018

ripcurlx commented Sep 11, 2018

ripcurlx commented Sep 12, 2018

cbeams commented Sep 12, 2018 via email

ManfredKarrer commented Sep 12, 2018

ripcurlx commented Sep 13, 2018

cbeams left a comment

Choose a reason for hiding this comment

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018 • edited Loading

ManfredKarrer commented Sep 18, 2018

ManfredKarrer Sep 18, 2018

Choose a reason for hiding this comment

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ripcurlx commented Sep 18, 2018

ripcurlx commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018 • edited Loading

ManfredKarrer commented Sep 18, 2018

ripcurlx commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018 • edited Loading

ripcurlx commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ManfredKarrer commented Sep 18, 2018

ripcurlx commented Sep 7, 2018 •

edited

Loading

ManfredKarrer commented Sep 18, 2018 •

edited

Loading

ManfredKarrer commented Sep 18, 2018 •

edited

Loading

ManfredKarrer commented Sep 18, 2018 •

edited

Loading