Verify all checksums in prepare-system.sh #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this for the jce_policy-8.zip file, but we also fetch the BC .jar over http and it could be trivially MitM'ed by a network adversary before this patch.
Consistently indent with four spaces.
Use ${foo} instead of $foo to expand variables.
Edit log messages to say e.g "Enabling foo..." instead of
"Enable foo" (the second sounds like we are telling the user
to do something).
Add log message at the end of script, so it shows a message even
if nothing needs to be done on the current run.
The -e makes any command that exits with non-success terminate the script. The -u makes any reference to an undefined variable exit with an error.
ripcurlx
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve style in general.