Add DAO code #1627
Merged
Add DAO code #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move code for broadcasting blind vote to p2p network and applying data to success handler of tx broadcast - Add popups when publishing blind vote
- Add transaction as param to onSuccess handler - Remove Broadcaster - Use onTimeout and onTxMalleability default implementation if not dedicated handling code was there
- Use ExceptionHandler at publishBlindVote - Add hasEnoughBsqFunds method to BlindVoteService - Show fee and confirmation popup at publish blind vote - Add GUIUtils.showBsqFeeInfoPopup to avoid code duplication - Add busyAnimation to publish blind vote button - Improve logs
- Add VoteResultService for all proposals - Use stake instead of nr. of votes for majority data view calculation - Use IssuanceService fro compensation requests - Add more checks at issuance - Use secondary sort by hex of hash for getMajorityHash - Add issued amount to dashboard view
Periodservice cycles
Revert "Periodservice cycles"
- Add MyProposalService and ProposalListService to split up responsibility and threading boundaries - Make ProposalService running in parser thread. Refactor resonsibilities. - Add thread context aware listeners - Use injectable NodeExecutor to make parsre thread accessible for thread context aware listeners - Add stream() method and Iterable<T> interface to PersistableList - Add ProposalFactory to create proposals from its payload - Add ProposalPayload and BlindVoteList to Tx - Add getLastOutput method to Tx
# Conflicts: # src/main/java/bisq/desktop/app/BisqApp.java
# Conflicts: # src/main/java/bisq/desktop/app/BisqApp.java
- Move BsqBlockchain data to ChainState - Add ChainStateService for accessing ChainState data - Replace ReadableBsqBlockChain and WritableBsqBlockChain with ChainStateService
- Remove immutable fields from Tx, TxInput adn TxOutput - Add maps to ChainState for mutable fields - Integrate BaseService in BlindVoteService - Remove ValidationCandidate and BaseService - Remove reset prameter at clone methods - Move validation out of valueObject into Validator classes to keep valueObjects small
- move bisq.core.dao.state.blockchain.vo to bisq.core.dao.state.blockchain
We create a immutable data unit Block which contains an immutable list of blockchain related blocks (TxBlock) and an immutable list of non-blockchain related events. Service classes which produces StateChangeEvents like ProposalService registers as stateChangeEventListProvider and returns a list of StateChangeEvents when a new TxBlock arrives. The stateService collect all those returned lists and put it to the newly created immutable Block. - Rename BsqBlock to TxBlock - Create Block class containing txBlock as delegate and stateChangeEvents - Add registerStateChangeEventListProvider method for clients processing a new TxBlock and producing stateChangeEvents - Rename StateService listeners to blockListeners - Pass Block instead of TxBlock at blockListeners.onBlockAdded - Rename StateService.Listener to StateService.BlockListener - Rename ParamChangeEvent to ChangeParamEvent - Make ChangeParamEvent extending StateChangeEvent - Make ChangeParam implementing ProtectedStoragePayload
- Move role package inside governance
- Fix issues with past refactorings (not applied imports)
- Rename bisq.core.dao.state.ext package to bisq.core.dao.state.governance
- Rename proposal view classes
We can use the txId as unique ID
Make Vote to BooleanVote
# Conflicts: # src/main/resources/i18n/displayStrings.properties Merge branch 'master' into voting # Conflicts: # build.gradle
# Conflicts: # src/main/resources/i18n/displayStrings.properties Merge branch 'master' into voting # Conflicts: # build.gradle
# Conflicts: # src/main/resources/i18n/displayStrings.properties Merge branch 'master' into voting # Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
bisq-network/bisq-common#34
bisq-network/bisq-p2p#16
bisq-network/bisq-core#150