Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default payment account for an edited offer to null #1583

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Set default payment account for an edited offer to null #1583

merged 2 commits into from
Jun 25, 2018

Conversation

ripcurlx
Copy link
Contributor

Fixes #1565.

@ripcurlx ripcurlx requested a review from ManfredKarrer June 25, 2018 09:56
ManfredKarrer
ManfredKarrer reviewed Jun 25, 2018
View reviewed changes
src/main/java/bisq/desktop/main/offer/EditableOfferDataModel.java Outdated
@@ -245,7 +245,7 @@ public boolean initWithData(OfferPayload.Direction direction, TradeCurrency trad
fillPaymentAccounts();

PaymentAccount account;
PaymentAccount lastSelectedPaymentAccount = preferences.getSelectedPaymentAccountForCreateOffer();
PaymentAccount lastSelectedPaymentAccount = getPreselectedPaymentAccount();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add @nullable annotations for all nullable fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ManfredKarrer
ManfredKarrer approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I don't have enough context to reason about the change. Will checkout the code once its complete and review all again.

ManfredKarrer
ManfredKarrer approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 1d4ac86 into bisq-network:master Jun 25, 2018
@ripcurlx ripcurlx mentioned this pull request Jul 30, 2018
Closed
@ripcurlx ripcurlx deleted the fix-currency-issues-after-editing-offer branch September 5, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ripcurlx @ManfredKarrer