Fix select currency issues after edit offer #1578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfredKarrer
suggested changes
Jun 22, 2018
| } | ||
|
|
||
| public void initWithData(OpenOffer openOffer) { | ||
| this.openOffer = openOffer; | ||
| this.initialState = openOffer.getState(); | ||
| this.paymentAccount = user.getPaymentAccount(openOffer.getOffer().getMakerPaymentAccountId()); | ||
| // select the current offer payment account as default payment account | ||
| preferences.setSelectedPaymentAccountForCreateOffer(paymentAccount); |
There was a problem hiding this comment.
Is that needed in the base class or should that be only called in the createOffer sub class? If so, maybe better to overwrite initWithData there.
There was a problem hiding this comment.
Actually this is already the edit offer sub class. The naming of the method is misleading, I'll rename it to a generic one.
| @@ -131,9 +131,9 @@ protected void deactivate() { | |||
| /////////////////////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| public void initWithData(OpenOffer openOffer) { | |||
| model.initWithData(openOffer); | |||
There was a problem hiding this comment.
I would prefer if we don't have that call before the super call. Carries risky dependencies of order of calls (see my comment in other commit - maybe that solves the issue without changing here the order?)
This reverts commit 175e11d.
This does the work that was intended to be done in commit 175e11d, but was done by first removing the dependencyVerification block entirely, and then replacing it with the output of the `calculateChecksums` task. The entire process went like this: 1. Remove existing dependencyVerification block from build.gradle 2. Run `./gradlew -q calculateChecksums | grep -v network.bisq:bisq- >> build.gradle` 3. Run `git diff` to see that only the checksums we expect to have changed have in fact changed (libdohj and bitcoinj in this case). 4. Commit the changes (in this commit) I'll update the instructions for the dependencyVerification block in a subsequent commit to make this clearer in the future.
- Use ProtobufferException for CoreNetworkProtoResolver.fromProto(PB.NetworkEnvelope proto) - Add raw PB data in case if an exception - log error if the encrypted data contains unknown PB data Note: We should refactor the resolvers with checked exceptions instead of the ProtobufferRuntimeException, but for the moment we leave that to not add too much complexity/risk for that release.
|
@ManfredKarrer: I think I somehow f** up this PR. I'll delete it an re-open a new one with a different strategy that makes it even easier to solve this issue 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1565.