Remove offer duplicates in spread view #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeams
approved these changes
Apr 10, 2018
| @@ -90,6 +94,12 @@ protected void deactivate() { | |||
| offerBookListItems.removeListener(listChangeListener); | |||
| } | |||
|
|
|||
| private static <T> Predicate<T> distinctByKey(Function<? super T, ?> keyExtractor) | |||
| { | |||
There was a problem hiding this comment.
Nit: place opening brace on same line
| public void testfilterSpreadItemsForUniqueOffers() { | ||
| OfferBook offerBook = mock(OfferBook.class); | ||
| PriceFeedService priceFeedService = mock(PriceFeedService.class); | ||
| final ObservableList<OfferBookListItem> offerBookListItems = FXCollections.observableArrayList(); |
There was a problem hiding this comment.
Nit: don't use final modifier on local variables unless strictly necessary (same for line 85 below.
There was a problem hiding this comment.
I use it out of a habit. Does it have a disadvantage to use final everywhere by default and only not use it where necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1202.
I was only able to reproduce it in a test in the SpreadModel so I added an additional safeguard there.