Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to BitcoinJ 0.12 #98

Closed
ManfredKarrer opened this issue Sep 28, 2014 · 4 comments
Closed

Upgrade to BitcoinJ 0.12 #98

ManfredKarrer opened this issue Sep 28, 2014 · 4 comments
Assignees
Milestone

Comments

@ManfredKarrer
Copy link
Contributor

BitcoinJ 0.12 will be released soon. Let's update to it when it does.

Note that this will require more than a simple change to dependency metadata. BitcoinJ has been repackaged from com.google => org.bitcoinj, so we'll have some search and replace work to do at the very least.

@ManfredKarrer ManfredKarrer added this to the M4 milestone Sep 28, 2014
@cbeams cbeams modified the milestones: M4, v1.0.0 Sep 29, 2014
@cbeams cbeams changed the title Update to latest master of BitcoinJ Update to BitcoinJ 0.12 Oct 1, 2014
@cbeams
Copy link
Contributor

cbeams commented Oct 1, 2014

Manfred, note that I've updated the title and description to reflect the news that 0.12 will be out soon.

@cbeams cbeams changed the title Update to BitcoinJ 0.12 Upgrade to BitcoinJ 0.12 Oct 1, 2014
cbeams added a commit that referenced this issue Oct 2, 2014
 - Update imports to reflect BitcoinJ's repackaging, including:

   git grep -l 'import com.google.bitcoin' | \
   xargs perl -p -i -e 's/import com.google.bitcoin/import org.bitcoinj/'

   git grep -l 'com.google.bitcoin' | \
   xargs perl -p -i -e 's/com.google.bitcoin/org.bitcoinj/'

 - Replace use of BitcoinJ's CoinFormat, which has now been renamed to
   MonetaryFormat, using:

   git grep -l 'CoinFormat' | \
   xargs perl -p -i -e 's/CoinFormat/MonetaryFormat/g'

 - Fix calls to BitcoinJ's Script#correctlySpends, whose signature has
   changed from 0.11 => 0.12.

See #98
@cbeams cbeams self-assigned this Oct 3, 2014
@cbeams cbeams modified the milestones: v0.1.0, v1.0.0 Oct 3, 2014
@cbeams
Copy link
Contributor

cbeams commented Oct 3, 2014

Manfred, #104 is ready to merge. Do you have any issue with me doing that now?

@ManfredKarrer
Copy link
Contributor Author

Yeah lets do the merge. I have to leave soon for an appointment so would be nice if you can do it yourself...

@cbeams
Copy link
Contributor

cbeams commented Oct 3, 2014

No problem. Just wanted to make sure you're aware of this. Will do shortly.

@cbeams cbeams closed this as completed in aab3154 Oct 3, 2014
@cbeams cbeams removed the 3: review label Oct 3, 2014
cbeams added a commit that referenced this issue Oct 3, 2014
 - Update imports to reflect BitcoinJ's repackaging, including:

   git grep -l 'import com.google.bitcoin' | \
   xargs perl -p -i -e 's/import com.google.bitcoin/import org.bitcoinj/'

   git grep -l 'com.google.bitcoin' | \
   xargs perl -p -i -e 's/com.google.bitcoin/org.bitcoinj/'

 - Replace use of BitcoinJ's CoinFormat, which has now been renamed to
   MonetaryFormat, using:

   git grep -l 'CoinFormat' | \
   xargs perl -p -i -e 's/CoinFormat/MonetaryFormat/g'

 - Fix calls to BitcoinJ's Script#correctlySpends, whose signature has
   changed from 0.11 => 0.12.

See #98
cbeams added a commit that referenced this issue Oct 3, 2014
@ManfredKarrer ManfredKarrer modified the milestone: v0.1 Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants