Fix Bank transfer 'Copy BSB number' bug

[Conza88]

Steps to reproduce

• Take offer
• National Bank Transfer method
• Go to pay trader, open trade ID details
• Hit copy the :BSB code: number
• *Instead it copies the BANK NAME, not the BSB code/number

Most certainly first world problems I know, but is a small fix hopefully.

May be present on OTHER bank payment methods as well.

[pazza83]

Thanks for this I will take a look.

[BtcContributor]

Not sure if I can reproduce that @Conza88, at least on 1.5.6.
If I click on the copy button I obtain the value of Bank name / BSB code together and it seems good to me.

Maybe it has already been fixed?

[Conza88]

Should it not just be the BSB number on its own?

You don't need the bank name when putting into transfer at all. The BSB and account number together look that up.

When I paste it currently into bsb box it pastes the stupid bank name instead and gets cut off

[BtcContributor]

I think that the copy button means copy everything in the box and that's what is happening right now.
If just the second part of the box is needed instead, I can propose a fix for that.

[Conza88]

That's exactly what I'm proposing.

…

________________________________ From: BtcContributor <[email protected]> Sent: Wednesday, February 24, 2021 6:41:21 AM To: bisq-network/bisq <[email protected]> Cc: Conza <[email protected]>; Mention <[email protected]> Subject: Re: [bisq-network/bisq] Fix Bank transfer 'Copy BSB number' bug (#5200) I think that the copy button means copy everything in the box and that's what is happening right now. If just the second part of the box is needed instead, I can propose a fix for that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#5200 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMLWYXMCVMHOF5IZ7FSQSDTAQAGDANCNFSM4XYFWT2A>.

[BtcContributor]

Fixed @Conza88.
It is trivial to add other similar scenarios, if needed.

[Conza88]

Awesome. Yes, pretty simple.

Is there any reason any bank transfers need the other bank name?

[BtcContributor]

Not sure about that.

[pazza83]

Is there any reason any bank transfers need the other bank name?

@Conza88, good question.

I think it is standard practice when making payment to someone to know the bank you are transferring to. However really the info is not needed as you have the BIC / Sort Code / BSB Code etc.

That being said I do not think it really gives too much away as because you have the above you would be able to find their bank name anyway.

Let me know if you think it is / is not needed.