Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Available balance pop-up currency wrong #3515

Closed
rafaelpac opened this issue Oct 30, 2019 · 3 comments · Fixed by #3539
Closed

Available balance pop-up currency wrong #3515

rafaelpac opened this issue Oct 30, 2019 · 3 comments · Fixed by #3539

Comments

@rafaelpac
Copy link
Contributor

Description

At the top right corner of the window, we have the drop down menu for BTC rates, the available balance, the reserved funds and locked funds (all these last 3 in BTC units).
When the mouse is over any of these last three, the software calculates the value in the respective rate and displays a pop-up with the value converted to whatever currency was selected in the drop down menu.
Even though the conversion is working alright, the symbol that is always shown is "USD".
For example, check below what happens when BTC/COP is selected (Colombian Peso):

image

I wish I had 702k USD!!! :-)

Version

v1.2.0

Steps to reproduce

Change the rate at the drop down and observe.

Expected behaviour

In the example above, the pop-up should show 702.324,79 COP.

Actual behaviour

Instead of showing "COP", it showed "USD" (it shows "USD" always)

@devinbileck
Copy link
Member

Thanks for reporting this. I know where the issue lies. I will work on a fix.

@rafaelpac
Copy link
Contributor Author

Thanks!
I am a total noob on Github. How should it go? If I find something like this and I know how to fix it in the code, how should I do it? Does something like this qualify to compensation on the DAO?

@devinbileck
Copy link
Member

If you know how/what to fix for this, feel free! If you submit a PR, once it gets merged to master, you are eligible for compensation.
Otherwise let me know and I can work on a fix.

devinbileck added a commit to devinbileck/bisq that referenced this issue Nov 1, 2019
When hovering over the BTC balances, the popup was using the market
price based on the locale combined with the preferred currency as its
units. This lead to the situation where it could show a mismatch
between value and units.

Instead, use the market price based on the preferred currency.

Fixes bisq-network#3515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants