Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rejected role is shows in bonded roles #3271

Closed
chimp1984 opened this issue Sep 16, 2019 · 1 comment · Fixed by #3676
Closed

Rejected role is shows in bonded roles #3271

chimp1984 opened this issue Sep 16, 2019 · 1 comment · Fixed by #3676
Labels
a:bug in:dao in:gui

Comments

@chimp1984
Copy link
Contributor

A rejected bonded role request (lio cycle 5) is displeyed in the bonded roles table. By clicking the role it throws an exception.
Expected: Rejected requests are filtered out.

java.lang.IllegalArgumentException: bondedRoleType must be present
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:122)
	at bisq.core.dao.DaoFacade.getRequiredBond(DaoFacade.java:721)
	at bisq.desktop.main.dao.bonding.roles.RoleDetailsWindow.addContent(RoleDetailsWindow.java:88)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:295)
	at bisq.desktop.main.dao.bonding.roles.RoleDetailsWindow.show(RoleDetailsWindow.java:66)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at bisq.desktop.main.dao.bonding.roles.RolesView$3$1.lambda$updateItem$0(RolesView.java:214)
@ben-kaufman
Copy link
Contributor

Can confirm the issue. If no one is on it yet I'll try to fix it.

ben-kaufman added a commit to ben-kaufman/bisq that referenced this issue Sep 24, 2019
@ben-kaufman
Show only active roles in "Bonded Roles" table
6e5d78b 
Fix bisq-network#3271.
Filter the bonded roles list to contain only active bonds in the RolesView table.
@ben-kaufman ben-kaufman mentioned this issue Sep 24, 2019
Closed
chimp1984 added a commit to chimp1984/bisq that referenced this issue Nov 24, 2019
@chimp1984
Only show accepted bonded roles in bond view.
ff10f7c 
Fixes bisq-network#3271

Replaces bisq-network#3320
@chimp1984 chimp1984 mentioned this issue Nov 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:dao in:gui
Projects
None yet
Milestone
No milestone
3 participants
@freimair @ben-kaufman @chimp1984