Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent wallet sizes #2797

Closed
yourwpguy opened this issue May 2, 2019 · 25 comments
Closed

Inconsistent wallet sizes #2797

yourwpguy opened this issue May 2, 2019 · 25 comments
Labels
in:wallet

Comments

@yourwpguy
Copy link

v1.0.1, Windows.
screen-003
bisq.log
@ripcurlx
Copy link
Contributor

ripcurlx commented May 3, 2019

@yourwpguy Was the dispute resolved properly after you've received this error popup?

@yourwpguy
Copy link
Author

I am not sure, which exactly dispute made this error. I had 2 open disputes before, and 1 failed trade. I assume the error popup after the failed trade. For that failed trade the arbitrator wrote: "your fee was not published either after a second check.".
I copied/pasted the last backuped wallet I know which was working.
Now I can start Bisq and resync.
But I am getting this error anyway again - "Inconsistent wallet sizes".
Right now I have 3 open disputes.

I wrote also here: bisq-network/support#247

@ripcurlx
Copy link
Contributor

ripcurlx commented May 3, 2019

@oscarguindzberg Do you have an idea how @yourwpguy could get rid of this issue?

@oscarguindzberg
Copy link
Contributor

@yourwpguy Your wallet file is corrupted.
Please, do a backup, then go to account/"wallet seed" and do a restore from seed.

@yourwpguy
Copy link
Author

But what about this?
screen-019

I have 3 not finalized (disputes are open) trades.

@oscarguindzberg
Copy link
Contributor

You are restoring the same wallet, so it is supposed to be ok.
As I said, do a backup of your bisq data dir before doing anything. You could go back to this backup if anything unexpected happens.

@yourwpguy
Copy link
Author

I did what you suggested. (Using v1.0.1 on Windows.)

Those two errors are still there.
screen-003
screen-004

Log file attached.
bisq2.log

@oscarguindzberg
Copy link
Contributor

Hi,
I saw the logs and I see the problem, your bitcoin wallet gets corrupted right after you do a restore from seed.
I still don't know why the problem happens and I can't reproduce it locally.

So, I suggest the following steps.

  • I assume you already have a backup of your bisq data dir.
  • Clear your bisq data dir and do a restore from seed. You will get access to your bitcoin wallet but won't have access to the trading history nor open disputes.
  • do a withdrawal of you bitcoin balance to an external wallet. Then you have your bitcoins in a safe place. The only thing left is the open disputes.
  • you send me in a private message the contents of your bisq data directory and wallet password. I wouldn't want to do that, but I see no other way to help you. Full disclosure: By doing so, you are giving me access/control to all your open disputes and bisq private information.

@ripcurlx please advise if this is the right way to deal with user private info.

@yourwpguy
Copy link
Author

Clear your bisq data dir and do a restore from seed. You will get access to your bitcoin wallet but won't have access to the trading history nor open disputes.

Will I get my funds which were locked from these two open disputes?

do a withdrawal of you bitcoin balance to an external wallet. Then you have your bitcoins in a safe place. The only thing left is the open disputes.

And what to do with the BSQ balance?

you send me in a private message..

How to send you a private message? I have sent you an email to your Gmail.

@yourwpguy
Copy link
Author

Was the dispute resolved properly after you've received this error popup?

I am not sure, if those two disputes were resolved properly. The funds were locked but after a while or after these error messages there are no more locked funds and if they were unlocked, I didn't receive them in my wallet. I don't know how to properly find out where these locked funds went.

@oscarguindzberg
Copy link
Contributor

oscarguindzberg commented May 6, 2019 via email

@oscarguindzberg
Copy link
Contributor

I have another idea:

So, I suggest the following steps.

  • Do a backup of your bisq data dir (backup 1)
  • Clear the contents of your bisq data dir and do a restore from seed. You will get access to your bitcoin and bsq wallet but won't have access to the trading history nor open disputes.
  • do a withdrawal of you bitcoin balance to an external wallet. Then you have your bitcoins in a safe place. The only thing left to recover are open disputes and bsq balance.
  • Close bisq
  • Do another backup of your bisq data dir (backup 2)
  • Clear the contents of your bisq data dir.
  • Copy to your bisq data dir the contents of "backup 1".
  • Delete your-bisq-data-directory/btc_mainnet/wallet directory
  • On your-bisq-data-directory/btc_mainnet/wallet put the content of "backup 2" btc_mainnet/wallet directory.
  • Restart bisq.
  • You should have access to your bsq tokens and see the status of your open disputes / failed trades. Proceed to solve the disputes / failed trades.
  • Please don't delete any backups, they might be useful for us, even if you fix your problem.

@oscarguindzberg oscarguindzberg mentioned this issue May 7, 2019
Closed
@oscarguindzberg
Copy link
Contributor

Status report

@yourwpguy sent his original bisq data dir in private and I could reproduce the bug.

bitcoinj wallet is corrupted.

Exception at startup:
org.bitcoinj.wallet.UnreadableWalletException: Wallet contained duplicate transaction 1debca5f5f8778497a538e7959c6b5280b1862c14c3eb1c8597bbc2249f871ea
at org.bitcoinj.wallet.WalletProtobufSerializer.readTransaction(WalletProtobufSerializer.java:680)
at org.bitcoinj.wallet.WalletProtobufSerializer.readWallet(WalletProtobufSerializer.java:507)
at org.bitcoinj.wallet.WalletProtobufSerializer.readWallet(WalletProtobufSerializer.java:444)
at bisq.core.btc.setup.WalletConfig.loadWallet(WalletConfig.java:548)
at bisq.core.btc.setup.WalletConfig.createOrLoadWallet(WalletConfig.java:506)
at bisq.core.btc.setup.WalletConfig.startUp(WalletConfig.java:382)
at com.google.common.util.concurrent.AbstractIdleService$DelegateService$1.run(AbstractIdleService.java:62)
at com.google.common.util.concurrent.Callables$4.run(Callables.java:122)
at java.base/java.lang.Thread.run(Thread.java:844)

This tx https://blockstream.info/tx/1debca5f5f8778497a538e7959c6b5280b1862c14c3eb1c8597bbc2249f871ea is duplicated in the wallet file.

I don't know how the bitcoinj wallet file ended up being corrupted.

After the user has followed the steps I wrote on my previous comment, he does not get an error on bisq startup anymore.

User says:

The corrupted wallet or error appeared after a trade, where the scammer was blocked:
I was selling BTC as taker.
Error message:
An error occurred at task: CheckIfPeerIsBanned
Other trader is banned by his trading account data.
Trade state: TAKER_FEE_PUBLISHED

@oscarguindzberg
Copy link
Contributor

oscarguindzberg commented May 8, 2019 •
edited
Loading

Then the user reports another problem:

"I can start Bisq and see the open disputes, but there were locked funds for 2 open disputes, but after the wallet was corrupted, they did disappear.
I already made withdrawal of my bitcoin balance to an external wallet."

@yourwpguy
Copy link
Author

Yes, and as those locked funds for 2 open disputes disappeared (I just didn't saw them as locked anymore and also didn't receive them in my wallet), I thought the arbitrator s6yrrpezc3zp6biy.onion:9999 closed the open disputes and I just didn't receive these locked funds because my wallet was corrupted.

@oscarguindzberg
Copy link
Contributor

As I can see on the user disputes, the disputes are not resolved by the arbitrator yet.

@oscarguindzberg
Copy link
Contributor

@ripcurlx I think this is now outside my area of expertise, I leave it to you to assign this issue to another developer to complete user support.

@yourwpguy Given you shared with me your data dir, I suggest to avoid using it in the future. Once you are finished solving this issue, please withdraw any btc/bsq you have and start with an empty data dir and don't reuse the seed words you currently have.

@oscarguindzberg oscarguindzberg mentioned this issue May 8, 2019
Closed
@yourwpguy
Copy link
Author

But howto receive now the locked funds from my two open disputes? I am quite unhappy with this situation. Still waiting for some support.
The wallet was corrupted. There are two open disputes with locked funds, but my wallet is showing 0.00 BTC locked. The disputes are not resolved.

@oscarguindzberg
Copy link
Contributor

@ManfredKarrer who would be the right person to to look into this?

@yourwpguy
Copy link
Author

@ManfredKarrer Dear Manfred, could you please appoint someone to look into this. My funds are locked already several weeks. There should be a way howto resolve this problem.

@devinbileck
Copy link
Member

Perhaps this now qualifies as a reimbursement request?

@yourwpguy
Copy link
Author

Everyone from the support is able to see my transactions. There should be a way howto unlock those funds. Other funds were unlocked from other disputed trades before the error, but these two trades not. I don't know why the arbitrator decided to hold them longer. And then the error occured.

@ManfredKarrer
Copy link
Contributor

@yourwpguy Can you PM me on the Bisq forum your deposit tx ID of the disputes in question?
If you check with cmd+e you can see the internal wallet balance. You can export all the tx history to a spreadsheet to check all in and outgoing transactions and see if they sum up to 0.

If the funds are still locked the arbitrator can unlock it.

s6yrrpezc3zp6biy

That is arbitrator "keo" on the Bisq Forum. Best to get in touch in case a dispute is still open. I hope it was not closed in favor to the other peer because you could not communicate with him and he did not know about the bug. Try to PM him on the forum as well to see how the disputes have been closed.

@keo-bisq
Copy link

I have reclosed the disputes twice. Please keep you app open such that it can publish the transactions correctly. I will continuously check if it works and wait for some time.

@yourwpguy
Copy link
Author

@keo-bisq Well, I received the funds now. Everything seems to be fine. Thank you!

@Drazen-V Drazen-V mentioned this issue Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ripcurlx @devinbileck @oscarguindzberg @ManfredKarrer @yourwpguy @keo-bisq