Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect voting cycle number shown after phases were changed #2706

Closed
devinbileck opened this issue Apr 12, 2019 · 1 comment
Closed

Incorrect voting cycle number shown after phases were changed #2706

devinbileck opened this issue Apr 12, 2019 · 1 comment
Labels
in:dao
Milestone
v1.1.0

Comments

@devinbileck
Copy link
Member

On DAO regtest, cycle 7 is shown as 5.
image

Potentially caused by recent changes to phase lengths by voting in cycle 6 (Proposal phase, Blind vote phase, and Break 3 were all changed).
@devinbileck
Copy link
Member Author

I was able to reproduce on my local regtest setup by changing the proposal phase to 8 (by DAO voting).
image

@ManfredKarrer ManfredKarrer added this to the v1.1.0 milestone Apr 13, 2019
ManfredKarrer added a commit that referenced this issue Apr 21, 2019
@ManfredKarrer
Merge pull request #2757 from sqrrm/count-voting-cycles
25931c0 
Count cycles correctly, fix #2706
@devinbileck devinbileck mentioned this issue May 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:dao
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@devinbileck @ManfredKarrer