Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication of error when vote reveal published out of phase #2704

Closed
devinbileck opened this issue Apr 12, 2019 · 1 comment
Closed

No indication of error when vote reveal published out of phase #2704

devinbileck opened this issue Apr 12, 2019 · 1 comment
Assignees
Milestone

Comments

@devinbileck
Copy link
Member

I had submitted my vote during the blind vote phase (DAO regtest network, cycle 6), and then went offline. I then later came back online in the subsequent proposal phase and my client sent a vote reveal transaction (https://explorer.bisq.network/tx.html?tx=0eb496f7ad0cdca09e4979d09ebfbcf61c764979977734cc456b900f1f7ff15c), and showed the popup indicating it was published.

However, when looking at the vote results for the previous cycle, it shows my vote results without any indication that my vote reveal was not published in time (and as a result is not valid).
image

Expected results:

  • Perhaps the vote reveal transaction should not have been published since it was out of phase?
  • Show an error icon as opposed to the thumbs up icon when viewing the vote results
@ManfredKarrer
Copy link
Contributor

Yes that is missing. Shoule be exceptional with mainnet version as 3 days should be enough for reveal. But yes need to be fixed.

@ManfredKarrer ManfredKarrer added this to the v1.1.0 milestone Apr 12, 2019
@ripcurlx ripcurlx modified the milestones: v1.1.0, v1.2.0 May 7, 2019
@sqrrm sqrrm self-assigned this Jun 15, 2019
@sqrrm sqrrm closed this as completed in 98b4fe0 Jun 19, 2019
fflo pushed a commit to fflo/bisq that referenced this issue Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants