-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate OS X installer binary #100
Comments
The Gradle JavaFX plugin requires Oracle JDK 8u20 or better. Travis CI currently runs something older, and does not have a roadmap for upgrading. This commit experiments with what Travis support suggested as a workaround. See #100
@ManfredKarrer, FYI for your usability testing, etc.: you can build the OS X installer by switching to the |
@cbeams: I just tried to build it from the latest version (native branch) but got that error: Manfreds-iMac:bitsquare-native mk$ gradle build FAILURE: Build failed with an exception.
BUILD FAILED |
Oops. Sorry, I should have mentioned that JDK 8u20 or better is required for this part of the build to work. |
ah ok need to update, btw. could you add install instructions for java on linux. I remember that it was a bit tricky and some linux guys are not familiar with java... |
Yeah, funny enough, they're actually embedded in our Travis config (at least for the moment, until Travis updates their default JDK to 8u20 or better): https://github.com/bitsquare/bitsquare/blob/native/.travis.yml#L5-L8
Of course that's just for Debian and its variants. Not sure what it looks like with RPM, Yum, etc. |
@cbeams: I updated java now but get that error: 23:05:17.459 [ERROR] [org.gradle.BuildExceptionReporter] Caused by: java.lang.ClassNotFoundException: org.codehaus.groovy.runtime.typehandling.ShortTypeHandling 23:05:17.426 [LIFECYCLE] [class org.gradle.TaskExecutionLogger] :jfxJar FAILED |
Make sure you run with ./gradlew. Your locally installed Gradle is probably too old.
Should work as well.
|
Great now its working. I just din't see the popups first but that was an issue of the controlsfx lib, we need to update to version org.controlsfx:controlsfx:8.0.6_20 (to bew compatible with the latest java version). I have checked that in both master and native branch. |
The plugin's jfx* tasks tie into the normal Gradle build lifecycle, such that `gradle build` will now generate executables and installers according to the OS on which the build is being run. These files are output to the `build/distributions` directory. Installers work as expected OS X and Linux at this point. Windows installers do build, but a very particular configuration is necessary on the Windows machine doing the building (this configuration is to be documented in #109). However, even when the configuration is in place and the MSI installer is successfully built, there is still a fatal error at installer execution time relating to a missing msvp100.dll file. See details at https://bitbucket.org/shemnon/javafx-gradle/issue/43. An issue has been created to track this from the Bitsquare side as well--see #108. The changes made in this commit are based on on the samples at http://bitbucket.org/shemnon/javafx-gradle and the article at http://jaxenter.com/tutorial-a-guide-to-the-gradle-javafx-plugin-46270.html The gradle/javafx.gradle file is copied directly from the sources in the bitbucket repository above, as is apparently the convention (not sure why this isn't part of the plugin itself, but that's a question to be addressed later). Resolves #66, #100 See #108, #109
Resolved with d16c274. |
Superseded by #243. |
See #66
The text was updated successfully, but these errors were encountered: