Merge pull request #6796 from alvasw/move_jvm_args_to_build_gradle_files

Move JVM args to build.gradle files
bisq-network · Aug 6, 2023 · c737a20 · c737a20
2 parents 0353ff9 + e999e8e
commit c737a20
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 19 deletions.
diff --git a/apitest/build.gradle b/apitest/build.gradle
@@ -2,7 +2,10 @@ plugins {
     id 'bisq.application'
 }
 
-mainClassName = 'bisq.apitest.ApiTestMain'
+application {
+    mainClass = 'bisq.apitest.ApiTestMain'
+    applicationDefaultJvmArgs = ['-Dlogback.configurationFile=apitest/build/resources/main/logback.xml']
+}
 
 // The external dao-setup.gradle file contains tasks to install and clean dao-setup
 // files downloaded from

diff --git a/build-logic/commons/src/main/groovy/bisq.application.gradle b/build-logic/commons/src/main/groovy/bisq.application.gradle
@@ -38,24 +38,6 @@ installDist {
         def unixScriptFile = file("${rootProject.projectDir}/bisq-$applicationName")
         unixScriptFile.text = unixScriptFile.text.replace(
                 'APP_HOME=$( cd "${APP_HOME:-./}.." && pwd -P ) || exit', 'APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit')
-
-        if (applicationName == 'desktop') {
-            def script = file("${rootProject.projectDir}/bisq-$applicationName")
-            script.text = script.text.replace(
-                    'DEFAULT_JVM_OPTS=""', 'DEFAULT_JVM_OPTS="-XX:MaxRAM=8g -Xss1280k -XX:+UseG1GC ' +
-                    '-XX:MaxHeapFreeRatio=10 -XX:MinHeapFreeRatio=5 -XX:+UseStringDeduplication ' +
-                    '-Djava.net.preferIPv4Stack=true"')
-        }
-
-        if (applicationName == 'apitest') {
-            // Pass the logback config file as a system property to avoid chatty
-            // logback startup due to multiple logback.xml files in the classpath
-            // (:daemon & :cli).
-            def script = file("${rootProject.projectDir}/bisq-$applicationName")
-            script.text = script.text.replace(
-                    'DEFAULT_JVM_OPTS=""', 'DEFAULT_JVM_OPTS="' +
-                    '-Dlogback.configurationFile=apitest/build/resources/main/logback.xml"')
-        }
     }
 }
 

diff --git a/desktop/build.gradle b/desktop/build.gradle
@@ -4,6 +4,13 @@ plugins {
     id "com.github.johnrengelman.shadow" version "5.2.0"
 }
 
+application {
+    mainClass = 'bisq.desktop.app.BisqAppMain'
+    applicationDefaultJvmArgs = ['-XX:MaxRAM=8g', '-Xss1280k', '-XX:+UseG1GC', '-XX:MaxHeapFreeRatio=10',
+                                 '-XX:MinHeapFreeRatio=5', '-XX:+UseStringDeduplication',
+                                 '-Djava.net.preferIPv4Stack=true']
+}
+
 apply from: 'package/package.gradle'
 
 shadowDistTar.enabled = false