Skip to content

Commit

Permalink
Tidy up DisputeView & fix broken comparator
Browse files Browse the repository at this point in the history
Simplify and factor out a 'getDisputeGroupsByTrade()' method, to group
disputes by trade ID, from the 'show(Compact|Full)Report()' method
logic. Also fix a broken comparator on the Market column, that missed a
'CurrencyUtil::getCurrencyPair' application to the RHS parameter.

Additionally, do some minor cleanup of the class:

  Make fields final where possible, unbox primitive, convert statement
  to expression lambdas, simplify some if-else branches, use a loop in
  in place of 'forEach' to allow local variable mutation, formatting.
  • Loading branch information
stejbac committed Oct 10, 2024
1 parent 0f626d4 commit b7330a2
Showing 1 changed file with 183 additions and 235 deletions.
Loading

0 comments on commit b7330a2

Please sign in to comment.