Skip to content

Commit

Permalink
Add proto fields to support trade fee currency choice
Browse files Browse the repository at this point in the history
This change adds proto support for paying maker fees in bsq or btc.
The implementation will come in a future PR.

- Added makerFeeCurrencyCode field to CreateOfferRequest proto.

- Added isCurrencyForMakerFeeBtc field to OfferInfo proto wrapper.

- Add takerFeeCurrencyCode field to TakeOfferRequest proto.
  • Loading branch information
ghubstan committed Nov 13, 2020
1 parent 3e98910 commit 9f033ee
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions proto/src/main/proto/grpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ message CreateOfferRequest {
uint64 minAmount = 7;
double buyerSecurityDeposit = 8;
string paymentAccountId = 9;
string makerFeeCurrencyCode = 10;
}

message CreateOfferReply {
Expand All @@ -105,13 +106,14 @@ message OfferInfo {
uint64 volume = 8;
uint64 minVolume = 9;
uint64 buyerSecurityDeposit = 10;
string paymentAccountId = 11;
string paymentMethodId = 12;
string paymentMethodShortName = 13;
string baseCurrencyCode = 14;
string counterCurrencyCode = 15;
uint64 date = 16;
string state = 17;
bool isCurrencyForMakerFeeBtc = 11;
string paymentAccountId = 12;
string paymentMethodId = 13;
string paymentMethodShortName = 14;
string baseCurrencyCode = 15;
string counterCurrencyCode = 16;
uint64 date = 17;
string state = 18;
}

///////////////////////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -198,6 +200,7 @@ service Trades {
message TakeOfferRequest {
string offerId = 1;
string paymentAccountId = 2;
string takerFeeCurrencyCode = 3;
}

message TakeOfferReply {
Expand Down

0 comments on commit 9f033ee

Please sign in to comment.