Merge pull request #6079 from ghubstan/8-remove-trdstats-service

Remove GetTradeStatistics service from grpc.proto [#8]
bisq-network · Feb 28, 2022 · 92b48af · 92b48af
2 parents d301b0d + a1f059d
commit 92b48af
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 97 deletions.
diff --git a/core/src/main/java/bisq/core/api/CoreApi.java b/core/src/main/java/bisq/core/api/CoreApi.java
@@ -30,7 +30,6 @@
 import bisq.core.trade.model.TradeModel;
 import bisq.core.trade.model.bisq_v1.Trade;
 import bisq.core.trade.model.bsq_swap.BsqSwapTrade;
-import bisq.core.trade.statistics.TradeStatistics3;
 import bisq.core.trade.statistics.TradeStatisticsManager;
 
 import bisq.common.app.Version;
@@ -47,7 +46,6 @@
 
 import com.google.common.util.concurrent.FutureCallback;
 
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
 import java.util.Set;
@@ -442,10 +440,6 @@ public void removeWalletPassword(String password) {
         walletsService.removeWalletPassword(password);
     }
 
-    public List<TradeStatistics3> getTradeStatistics() {
-        return new ArrayList<>(tradeStatisticsManager.getObservableTradeStatisticsSet());
-    }
-
     public int getNumConfirmationsForMostRecentTransaction(String addressString) {
         return walletsService.getNumConfirmationsForMostRecentTransaction(addressString);
     }

diff --git a/daemon/src/main/java/bisq/daemon/grpc/GrpcGetTradeStatisticsService.java b/daemon/src/main/java/bisq/daemon/grpc/GrpcGetTradeStatisticsService.java
diff --git a/daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java b/daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java
@@ -56,7 +56,6 @@ public GrpcServer(CoreContext coreContext,
                       GrpcPriceService priceService,
                       GrpcShutdownService shutdownService,
                       GrpcVersionService versionService,
-                      GrpcGetTradeStatisticsService tradeStatisticsService,
                       GrpcTradesService tradesService,
                       GrpcWalletsService walletsService) {
         this.server = ServerBuilder.forPort(config.apiPort)
@@ -67,7 +66,6 @@ public GrpcServer(CoreContext coreContext,
                 .addService(interceptForward(paymentAccountsService, paymentAccountsService.interceptors()))
                 .addService(interceptForward(priceService, priceService.interceptors()))
                 .addService(shutdownService)
-                .addService(interceptForward(tradeStatisticsService, tradeStatisticsService.interceptors()))
                 .addService(interceptForward(tradesService, tradesService.interceptors()))
                 .addService(interceptForward(versionService, versionService.interceptors()))
                 .addService(interceptForward(walletsService, walletsService.interceptors()))

diff --git a/proto/src/main/proto/grpc.proto b/proto/src/main/proto/grpc.proto
@@ -444,22 +444,6 @@ message MarketPriceReply {
     double price = 1;           // The most recently available market price.
 }
 
-/*
-* GetTradeStatistics service is not implemented.  It's stub will be remove from the gRPC daemon.
-*/
-service GetTradeStatistics {
-    // Not implemented.
-    rpc GetTradeStatistics (GetTradeStatisticsRequest) returns (GetTradeStatisticsReply) {
-    }
-}
-
-message GetTradeStatisticsRequest {
-}
-
-message GetTradeStatisticsReply {
-    repeated TradeStatistics3 TradeStatistics = 1;
-}
-
 service ShutdownServer {
     // Shut down a local Bisq daemon.
     rpc Stop (StopRequest) returns (StopReply) {
@@ -469,7 +453,6 @@ service ShutdownServer {
 message StopRequest {
 }
 
-
 message StopReply {
 }