Fix code quality issues

Per Codacy report at https://app.codacy.com/gh/bisq-network/bisq/pullRequest?prid=4835062 Note that the items claiming that bisq.common.config.Config.* is an unused import are false positives. These imports are in fact used in every case.
bisq-network · Jan 17, 2020 · 918c6c1 · 918c6c1
1 parent 83a2fc8
commit 918c6c1
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 15 deletions.
diff --git a/common/src/main/java/bisq/common/crypto/CryptoUtils.java b/common/src/main/java/bisq/common/crypto/CryptoUtils.java
@@ -17,8 +17,6 @@
 
 package bisq.common.crypto;
 
-import bisq.common.util.Utilities;
-
 import javax.crypto.Cipher;
 
 import java.security.NoSuchAlgorithmException;

diff --git a/common/src/test/java/bisq/common/config/ConfigFileOptionTests.java b/common/src/test/java/bisq/common/config/ConfigFileOptionTests.java
@@ -1,11 +1,9 @@
 package bisq.common.config;
 
-import org.junit.Assert;
 import org.junit.Test;
 
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.contains;
 
 public class ConfigFileOptionTests {
 

diff --git a/core/src/main/java/bisq/core/btc/BitcoinModule.java b/core/src/main/java/bisq/core/btc/BitcoinModule.java
@@ -37,7 +37,6 @@
 
 import com.google.inject.Singleton;
 import com.google.inject.TypeLiteral;
-import com.google.inject.name.Names;
 
 import java.io.File;
 
@@ -83,7 +82,7 @@ protected void configure() {
         bindConstant().annotatedWith(named(Config.NUM_CONNECTIONS_FOR_BTC)).to(config.numConnectionsForBtc);
         bindConstant().annotatedWith(named(Config.USE_ALL_PROVIDED_NODES)).to(config.useAllProvidedNodes);
         bindConstant().annotatedWith(named(Config.IGNORE_LOCAL_BTC_NODE)).to(config.ignoreLocalBtcNode);
-        bindConstant().annotatedWith(Names.named(Config.SOCKS5_DISCOVER_MODE)).to(config.socks5DiscoverMode);
+        bindConstant().annotatedWith(named(Config.SOCKS5_DISCOVER_MODE)).to(config.socks5DiscoverMode);
         bind(new TypeLiteral<List<String>>(){}).annotatedWith(named(PROVIDERS)).toInstance(config.providers);
 
         bind(AddressEntryList.class).in(Singleton.class);

diff --git a/desktop/src/test/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModelTest.java b/desktop/src/test/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModelTest.java
@@ -23,10 +23,6 @@
 
 import bisq.core.locale.GlobalSettings;
 import bisq.core.provider.price.PriceFeedService;
-import bisq.core.util.coin.CoinFormatter;
-import bisq.core.util.coin.ImmutableCoinFormatter;
-
-import bisq.common.config.Config;
 
 import javafx.beans.property.SimpleIntegerProperty;
 
@@ -49,8 +45,6 @@
 
 public class OfferBookChartViewModelTest {
 
-    private final CoinFormatter coinFormatter = new ImmutableCoinFormatter(Config.baseCurrencyNetworkParameters().getMonetaryFormat());
-
     @Before
     public void setUp() {
         GlobalSettings.setDefaultTradeCurrency(usd);

diff --git a/p2p/src/main/java/bisq/network/p2p/P2PModule.java b/p2p/src/main/java/bisq/network/p2p/P2PModule.java
@@ -37,7 +37,6 @@
 
 import com.google.inject.Singleton;
 import com.google.inject.TypeLiteral;
-import com.google.inject.name.Names;
 
 import java.time.Clock;
 
@@ -75,11 +74,11 @@ protected void configure() {
 
         requestStaticInjection(Connection.class);
 
-        bindConstant().annotatedWith(Names.named(USE_LOCALHOST_FOR_P2P)).to(config.useLocalhostForP2P);
+        bindConstant().annotatedWith(named(USE_LOCALHOST_FOR_P2P)).to(config.useLocalhostForP2P);
 
         bind(File.class).annotatedWith(named(TOR_DIR)).toInstance(config.torDir);
 
-        bind(int.class).annotatedWith(Names.named(NODE_PORT)).toInstance(config.nodePort);
+        bind(int.class).annotatedWith(named(NODE_PORT)).toInstance(config.nodePort);
 
         bindConstant().annotatedWith(named(MAX_CONNECTIONS)).to(config.maxConnections);