Merge pull request #2475 from freimair/memoryleak_be_gone

Fixed memory leak in message throttle mechanism
bisq-network · Feb 27, 2019 · 76e406a · 76e406a
2 parents d68198e + 03a20a0
commit 76e406a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/p2p/src/main/java/bisq/network/p2p/network/Connection.java b/p2p/src/main/java/bisq/network/p2p/network/Connection.java
@@ -378,9 +378,10 @@ private boolean violatesThrottleLimit(NetworkEnvelope networkEnvelope) {
                             .collect(Collectors.toList()).toString());
                 }
             }
-            // we limit to max 1000 (MSG_THROTTLE_PER_10SEC) entries
-            messageTimeStamps.remove(0);
         }
+        // we limit to max 1000 (MSG_THROTTLE_PER_10SEC) entries
+        while(messageTimeStamps.size() > MSG_THROTTLE_PER_10_SEC)
+            messageTimeStamps.remove(0);
 
         messageTimeStamps.add(new Tuple2<>(now, networkEnvelope));
         return violated;