Add an extra byte to fee calculation to prevent rounding down

bisq-network · Oct 10, 2019 · 531db83 · 531db83
1 parent 7bed73e
commit 531db83
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java b/core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java
@@ -896,7 +896,7 @@ public Transaction getFeeEstimationTransaction(String fromAddress,
                 SendRequest sendRequest = getSendRequest(fromAddress, toAddress, amount, fee, aesKey, context);
                 wallet.completeTx(sendRequest);
                 tx = sendRequest.tx;
-                txSize = tx.bitcoinSerialize().length;
+                txSize = tx.bitcoinSerialize().length + 1; // add an extra satoshi for rounding bug
                 printTx("FeeEstimationTransaction", tx);
             }
             while (feeEstimationNotSatisfied(counter, tx));
@@ -945,7 +945,7 @@ public Transaction getFeeEstimationTransactionForMultipleAddresses(Set<String> f
                 SendRequest sendRequest = getSendRequestForMultipleAddresses(fromAddresses, dummyReceiver, amount, fee, null, aesKey);
                 wallet.completeTx(sendRequest);
                 tx = sendRequest.tx;
-                txSize = tx.bitcoinSerialize().length;
+                txSize = tx.bitcoinSerialize().length + 1; // add an extra satoshi for rounding bug
                 printTx("FeeEstimationTransactionForMultipleAddresses", tx);
             }
             while (feeEstimationNotSatisfied(counter, tx));
@@ -983,7 +983,7 @@ public int getEstimatedFeeTxSize(List<Coin> outputValues, Coin txFee)
         sendRequest.ensureMinRequiredFee = false;
         sendRequest.changeAddress = dummyAddress;
         wallet.completeTx(sendRequest);
-        return transaction.bitcoinSerialize().length;
+        return transaction.bitcoinSerialize().length + 1; // add an extra satoshi for rounding bug
     }