Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove monitor.bisq.network links #444

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

xanoni
Copy link
Contributor

@xanoni xanoni commented Sep 26, 2021

Commented out the monitor for now given it's been broken for a year or
so, which could be wrongly interpreted as "Bisq itself has problems".

Files affected: _data/*.yml

See:

@ripcurlx
Copy link
Contributor

Yes, probably a good idea as long it is not fixed. I still use parts of the KPIs, but no need to link to it publicly as long as not everything is up and running.

@m52go
Copy link
Contributor

m52go commented Sep 27, 2021

@xanoni agree, thanks for the suggestion. However, a better way to implement this would be to comment out the last line in _layouts/page_stats.html. Could you please make this change and rebase / resubmit?

@xanoni
Copy link
Contributor Author

xanoni commented Sep 28, 2021

@xanoni agree, thanks for the suggestion. However, a better way to implement this would be to comment out the last line in _layouts/page_stats.html. Could you please make this change and rebase / resubmit?

Yes, that's definitely cleaner. I didn't realize it was that easy.

Commented out the "monitor" site link for now, given it's been broken for a year or
so, which could be wrongly interpreted as "Bisq itself has problems".

Files affected: _layouts/page_stats.html

See (non-exhaustive list of related discussions):
- bisq-network/bisq#5297 (comment)
- bisq-network/bisq#5340
- bisq-network/compensation#685 (comment)
@xanoni xanoni force-pushed the comment-out-monitor branch from bbcd620 to 83004e3 Compare September 28, 2021 04:00
@m52go
Copy link
Contributor

m52go commented Sep 28, 2021

utACK

@m52go m52go merged commit 79796a1 into bisq-network:master Sep 28, 2021
@xanoni xanoni deleted the comment-out-monitor branch September 28, 2021 04:02
@xanoni
Copy link
Contributor Author

xanoni commented Sep 28, 2021

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants