Russian lang #339
Merged
Russian lang #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoMasutti
suggested changes
Feb 10, 2020
ru/images/DAO/dao_benefits.svg
Outdated
| sodipodi:role="line" | ||
| x="472.00201" | ||
| y="2572.8069" | ||
| id="tspan4665">negociação</tspan> |
There was a problem hiding this comment.
This is portuguese, not russian
There was a problem hiding this comment.
true. nice catch. let me replace with the eng one then. because our Ru translators stopped replying
|
There are many strings translated incorrectly. |
|
Updated the images to the English version as pointed out by @RiccardoMasutti we don't have documented exactly where to fetch these strings from Transifex. They probably are translated there but without a way to verify it I rather keep in Eng. We can plan on translating this at a later PR but I believe being in English is enough to publish |
m52go
pushed a commit
to m52go/bisq-website
that referenced
this pull request
Apr 24, 2020
DAO images are still in English, but without other errors. Russian translations will be done once the strings are in Transifex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the two missing strings on the
bisq-website/_data/languages.ymlfolderShould be good to go now