Display name of languages and country flag in locale selector #242
Conversation
wiz
commented
Sep 10, 2019
•
wiz
commented
- Use full language name instead of two letter language code
- Use flag emoji instead of two letter country code
- Fix sort order of locale selector pull-down
|
I agree this would be better, but responsiveness becomes an issue for languages with longer names. Desktop
Mobile
|
wiz
force-pushed
the
fix-language-selector
branch
2 times, most recently
from
303acda to
5cc30c8
Compare
wiz
changed the title
wiz
force-pushed
the
fix-language-selector
branch
from
5cc30c8 to
49f189b
Compare
- Use full language name instead of two letter language code - Use flag emoji instead of two letter country code - Fix sort order of locale selector pull-down
wiz
force-pushed
the
fix-language-selector
branch
from
49f189b to
92593c8
Compare
|
ACK |
|
Flags are not a good idea when dealing with localizations. They can create confusion (a country flag doesn't rappresent a language) and in some cases even conflicts. I don't agree with this change, i would have NACKed it before but this PR, that changes 59 files, was merged 6 hours after its creation (which is still a very bad and dangerous workflow IMHO) and i wasn't able to see it before now. Please don't rush with the merges. Beside the dangers, it's very hard to keep up with the development when PRs are merged after few hours. |
|
@erciccione let's handle the discussion of this commit in #243, and continue discussion about merges on Slack in #bisq-website. |
