Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runnable from root dir #5

Merged

Conversation

ghubstan
Copy link
Member

This change copies the build's distribution bisq-pricenode script & lib dir to the project root dir.

It follows the bisq repo build convention making all of its apps runnable from the bisq project root dir. The customized assemble task is a bit messy, and will have to be copy/pasted into other build files for new repos pulled out of the original bisq repo. (A re-usable gradle plugin for this task will probably be factored out of this build file's assemble task in another PR.)

Add building source code section
Follow bisq repo build convention making all of its apps runnable from
the bisq project root dir.  The customized assemble task is  ugly,
and will have to be copy/pasted into other build files pulled out
of the original bisq repo.  (So, a gradle plugin will be factored
out of this in another commit.)
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@bisq-github-admin-3 bisq-github-admin-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #5 (review)

@bisq-github-admin-3 bisq-github-admin-3 merged commit bbb2c4c into bisq-network:main Jul 13, 2022
@ghubstan ghubstan deleted the make-runnable-from-root-dir branch July 13, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants