Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale prices that have not been updated for over 10 minutes. #36

Merged
merged 2 commits into from Oct 30, 2023
Merged

Remove stale prices that have not been updated for over 10 minutes. #36

merged 2 commits into from Oct 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2023

In reference to issue #33, stale prices were observed when the pricenode stopped invoking a provider. This PR detects and removes prices that have not been updated for over 10 minutes.

Based on #35

@gabernard
Copy link
Contributor

@alvasw Could you please review this PR? Thank you.

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@gabernard gabernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gabernard gabernard merged commit fe73045 into bisq-network:main Oct 30, 2023
@ghost ghost mentioned this pull request Oct 31, 2023
@ghost ghost mentioned this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants