Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/android node networking POC integration #38

Merged
merged 24 commits into from
Nov 13, 2024
Merged

Feature/android node networking POC integration #38

merged 24 commits into from
Nov 13, 2024

Conversation

rodvar
Copy link
Collaborator

@rodvar rodvar commented Nov 13, 2024

  • Implementation for Integrate full node POC code into Bisq-mobile project #6
  • with this PR the androidNode app is in a state where it shows on screen anything that has been developed in shared adding the below:
    • connects to bisq2 network
    • creates a profile if not created and persisted already
    • observes and logs network information
    • listens for private messaging (this is gonna be our trading mechanism!)
    • listens for public messaging (for chat / not included in the MVP but nice to have)
  • to not over complicate things its left like this for further development on architecture that's coming to happen.

HenrikJannsen and others added 23 commits November 13, 2024 11:10
@HenrikJannsen @rodvar
Remove protobuf files and i18n resources
75b9cf3
@HenrikJannsen @rodvar
Remove mobile package (was first dev app with showing version number)
8409358
@HenrikJannsen @rodvar
Add multidex dependency, add protobuf source path
b03f572
@rodvar
- small adaptations on android native POC whilst understanding it
173ac68
@rodvar
- convert android native POC code to Kotlin for easier transition
013c631
@rodvar
- replace completable future with coroutines job
ee7a7bd
@rodvar
- protobuf fixes on POC merged from boilingfrog, fully communicates …
d4f3715 
…with seednode now (thanks Henrik!)
@rodvar
- integration of last commit into the androidNode
a2428a7
@rodvar
- integrated services from POC with all their dependencies, ready to…
bd95fb7 
… be used
@rodvar
- initialize services, added typesafe conf where its expecting it
ed0c7c9
@rodvar
- integration of print default sec key and language, printing on sys…
7956c55 
…tem.out
@rodvar
Added Koin Dependency (bisq-network#31)
ea13fed 
* Added Koin Dependency

At this stage, have only added in build.gradle.kts file under comman
code.

* Added sample code on android side

* Added di under shared package

* Added Koin under ios

* Fix - Renaming files

* Added Koin to Android Node

* Fix - Reformat the code

* Fix - fomatting again
@rodvar
- integrated services from POC with all their dependencies, ready to…
884f719 
… be used
@rodvar
- hardcode presenter dependency till issues with DI Koin and android…
439775b 
…Node gets fixed
@rodvar
- remove protobuf lite dep causing trouble with protobuf in bisq2 ja…
f660262 
…rs on runtime
@rodvar
- capable of creating profile if non existent and gets persisted
554ecd6
@rodvar
- observe network changes and log, fetch and print btc market price
d50bc99
@rodvar
- private messaging (trading) integration
ac67e0e
@rodvar
- public messaging integration
90b621d
@rodvar
- Implementation for android node memory report integrated with main…
5301180 
… service + junit setup and test for the new code
@rodvar
- android node ci config to use its own presenter as main
49fe426
@rodvar
- integration of app state
31281fd
@rodvar
- add cleanup on presenter destruction
a093cff
@rodvar rodvar self-assigned this Nov 13, 2024
@rodvar rodvar marked this pull request as ready for review November 13, 2024 03:04
HenrikJannsen
HenrikJannsen approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@rodvar rodvar merged commit 66605d1 into bisq-network:main Nov 13, 2024
1 check passed
@rodvar rodvar deleted the feature/android_node_networking_integration branch November 13, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees

@rodvar rodvar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodvar @HenrikJannsen