Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buy/Sell: Provide a way to create offer from this tab as well #114

Closed
rodvar opened this issue Dec 12, 2024 · 8 comments
Closed

Buy/Sell: Provide a way to create offer from this tab as well #114

rodvar opened this issue Dec 12, 2024 · 8 comments
Assignees
@nostrbuddha
Labels
In Progress low-prio issue is low priority whilst having this label UI
Milestone
MVP (version 0.1.0)

Comments

@rodvar
Copy link
Collaborator

rodvar commented Dec 12, 2024

The most natural since the user is browsing offers in this tab would be a circular (+) icon maybe at the bottom right of the screen as many messaging apps use
@rodvar rodvar added low-prio issue is low priority whilst having this label UI labels Dec 12, 2024
@rodvar rodvar added this to the MVP (version 0.1.0) milestone Dec 12, 2024
@rodvar
Copy link
Collaborator Author

rodvar commented Dec 12, 2024

not in the designs but there is no way to access create offer from the buy/sell trading screen

@nostrbuddha
Copy link
Contributor

Yes. I will do this.

nostrbuddha added a commit to nostrbuddha/bisq-mobile that referenced this issue Dec 25, 2024
@nostrbuddha
- Create offer FAB button in Offer list screen (bisq-network#114)
c75b2c7
nostrbuddha added a commit to nostrbuddha/bisq-mobile that referenced this issue Dec 26, 2024
@nostrbuddha
- Create offer FAB button in Offer list screen (bisq-network#114)
0bdc555
@nostrbuddha nostrbuddha mentioned this issue Dec 26, 2024
Merged
nostrbuddha added a commit to nostrbuddha/bisq-mobile that referenced this issue Dec 27, 2024
@nostrbuddha
- Create offer FAB button in Offer list screen (bisq-network#114)
44e59c6
rodvar pushed a commit to nostrbuddha/bisq-mobile that referenced this issue Jan 6, 2025
@nostrbuddha @rodvar
- Create offer FAB button in Offer list screen (bisq-network#114)
1dc567c
@rodvar
Copy link
Collaborator Author

rodvar commented Jan 7, 2025

We have already this only once the user has selected the market. Since we already have everything to do it, ideally we should also have one ( + ) button directly in the buy/sell tab and in this case it will take you to the select currencies screen.

Do you see this easily done @nostrbuddha ?

@nostrbuddha
Copy link
Contributor

Yes. It's simple. Will do.

  • Just that it will anyways take user to Buy/Sell buttons screen only, which will be followed by currency selection screen. right?
  • Unlike the '+' button in OfferList screen, which will navigate to Buy/Sell buttons screen, which will bypass currency selection screen.

@rodvar
Copy link
Collaborator Author

rodvar commented Jan 7, 2025

Yes. It's simple. Will do.

  • Just that it will anyways take user to Buy/Sell buttons screen only, which will be followed by currency selection screen. right?
  • Unlike the '+' button in OfferList screen, which will navigate to Buy/Sell buttons screen, which will bypass currency selection screen.

correct, so to put it in very simple plain words

  • If user navigates to buy/sell tab there is no currency selected, so the ( + ) button should "ask" for which currency market the user wants to add (+) an offer
  • if the user is in buy/sell and already selected a currency market , we already have your ( + ) implementation which is just fine

makes sense? Thanks Buddha!

rodvar added a commit that referenced this issue Jan 7, 2025
@nostrbuddha @rodvar
UI: Various improvements and fixes (#142)
22d3cc6 
* - My Trades UI (#132), Trading UI Dialogs (#131)

* - Create offer FAB button in Offer list screen (#114)

* - showSnackBar() in BasePresenter. Tested in androidNode, androidClient. Having some other resource loading issue with iOS, not able to test.

* - Copy, Paste, Scan QR (Tested in android)

* - Code refactor: CloseIcon

* Removed QR Code Scanner for this PR

* Fix: Missing Icon imports

* Offer card layout - Experimenting

* - file refactorings: Removed duplicate OfferListPresenter in 'offers'; moved all files from 'offers' to 'offer' and from 'trades' to 'trade'

* - [fix] Create Offer nav issue

* - Remove Take offer nav stack, when Take offer flow is confirmed and TradeFlow nav happens; Snackbar warnings in PaymentMethod screen, when payment method is not selected

* - removed qr related code; removed dead code; Snackbar color - Dark text over white BG

* Take offer UI Improvements
 - AmountScreen - Amount selector - Placed vertically center;
 - PaymentMethodScreen - Make use of PaymentMethodCard as done in Createoffer flow;
 - ReviewScreen - BisqUIConstants;

Misc UI Improvements
 - CreateOfferPaymentMethodScreen - Adjust spacing;
 - BisqAmount select - Comment on usage

* - Fixed compile time issues

* [Fix] Back navigation

* - added potential implementation for ios BackHAndler commented for now as explained in the TODO

---------

Co-authored-by: Rodrigo Varela <[email protected]>
@nostrbuddha
Copy link
Contributor

Yes. Done and pushing this as part of Chat UI

@rodvar rodvar mentioned this issue Jan 9, 2025
Merged
@rodvar
Copy link
Collaborator Author

rodvar commented Jan 9, 2025

well done @nostrbuddha . on the polishing stage before release we might round the button a bit and make the "+" thicker to make it more noticeable (or use an image)

@rodvar rodvar closed this as completed Jan 9, 2025
@nostrbuddha
Copy link
Contributor

Noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nostrbuddha nostrbuddha

Labels
In Progress low-prio issue is low priority whilst having this label UI
Projects
None yet
Milestone
MVP (version 0.1.0)
Development

No branches or pull requests
2 participants
@rodvar @nostrbuddha