-
Notifications
You must be signed in to change notification settings - Fork 88
Conversation
Looks great at a glance, @m52go, I'll provide more detailed comments later, but in the meantime, I've pushed a couple review commits, please see and study them above. A few other nits:
Links to and further information about each of these things can be found in the contributor checklist. Note that you can go back and touch up your existing commits with |
This commit squashes 3 other commits I made while working on this the first time. They broke convention & weren't particularly useful, so I combined them.
Apparently someone updated the desktop client to remove these pre-filled fields.
This PR was pretty horrible from a git perspective. I've cleaned everything up...updated old commit messages, set up signing, and made a new branch. Looks like the only thing I can't do is switch away from master on this PR. Should I just submit a new PR (for consistency with the rest of the repo), since there's no discussion here yet about this PR content? |
Sure, @m52go, feel free to close this and issue a new pull request from your new branch. Before you do, though, make sure your new branch actually contains only the commits related to this doc. Notice above how there are commits from Bernard and me that have nothing to do with this doc? This is part of the reason that issuing pull requests from The easiest thing to do should be the following:
If any of that doesn't work or doesn't make sense, just let me know. |
Also, please reference this pull request in the description of your new pull request, with a quick note as to why you created the new one, just for posterity. |
Also @m52go, when you create your new pull request, please reference #37 in the description. Whenever you're creating a pull request that relates to some already existing issue, it's a good idea to link to it in this way, so that the pull request is discoverable from the original issue (the reference causes a link to the pull request to show up in the original issue's event timeline). |
Please refer to #45 for updates. |
I probably went a little overboard for what's supposed to be an outline, but there's still plenty to do. I'm aware that the extra work I did is my own liability.