This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
Prune TradeStatisticsManager#printAllCurrencyStats #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be dead code, see @blabno's inquiry about it at https://bisq.slack.com/archives/C1267HFD1/p1521801524000052. If this is in fact *not* dead code, i.e. it gets used to print out certain reports at release boundaries, I suggest we still kill it here, and re-write that code in such a way that it (a) uses the new bisq.asset infrastructure and (b) doesn't require duplicating ticker symbols in this class. This work was intended for inclusion in bisq-network#32.
|
We could consider to automatially de-list assets which have not been traded in a certain period. The delisting would happen first just be excluding them in the displayed list, so users cannot select them anymore. To get a report which assets got delisted to remove code would be good as well. |
|
That would require that we start tracking a Otherwise, is this an ACK, Manfred? Please just merge if you're good with the change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be dead code, see @blabno's inquiry about it at
https://bisq.slack.com/archives/C1267HFD1/p1521801524000052.
If this is in fact not dead code, i.e. it gets used to print out
certain reports at release boundaries, I suggest we still kill it here,
and re-write that code in such a way that it (a) uses the new bisq.asset
infrastructure and (b) doesn't require duplicating ticker symbols in
this class.
This work was intended for inclusion in #32.