Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

List Madbyte (MBYT) #47

Closed
wants to merge 1 commit into from
Closed

List Madbyte (MBYT) #47

wants to merge 1 commit into from

Conversation

madbytecoin
Copy link

Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK
You must add separate test class in bisq.asset.coins package just like https://github.com/bisq-network/bisq-core/blob/master/src/test/java/bisq/asset/coins/DecentTest.java

@@ -306,6 +306,8 @@ private void printAllCurrencyStats() {
newlyAdded.add("GEO");
newlyAdded.add("GRANS");
newlyAdded.add("ICH");
newlyAdded.add("MBYT");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not touch this file.

@@ -133,6 +133,7 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) {
result.add(new CryptoCurrency("GRC", "Gridcoin"));
if (!baseCurrencyCode.equals("LTC"))
result.add(new CryptoCurrency("LTC", "Litecoin"));
result.add(new CryptoCurrency("MBYT", "Madbyte"));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not touch this file.

@@ -988,6 +988,21 @@ public void testPHR() {
assertFalse(validator.validate("").isValid);
}

@Test
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbeams do we want anybody to touch this file anymore?

@cbeams
Copy link
Contributor

cbeams commented Apr 3, 2018

Instructions for how to list an asset are being changed as we type. Stay tuned for further updates.

@cbeams
Copy link
Contributor

cbeams commented Apr 5, 2018

The process for listing an asset has recently changed (see #32), and I am now closing this pull request along with all other outstanding asset listing pull requests.

Please read and follow the new instructions at https://bisq.network/list-asset and re-submit a new pull request when ready. Note that Bisq v0.7.0 will likely ship within the next week, so you should still be able to get your asset listed in time for that release. Thanks.

@cbeams cbeams closed this Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants