-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
madbytecoin
commented
Apr 3, 2018
- Official block explorer URL: http://explorer.madbyte.com:3001/
- altcoin (based on Litecoin)
- Official project URL: http://madbyte.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK
You must add separate test class in bisq.asset.coins
package just like https://github.com/bisq-network/bisq-core/blob/master/src/test/java/bisq/asset/coins/DecentTest.java
@@ -306,6 +306,8 @@ private void printAllCurrencyStats() { | |||
newlyAdded.add("GEO"); | |||
newlyAdded.add("GRANS"); | |||
newlyAdded.add("ICH"); | |||
newlyAdded.add("MBYT"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not touch this file.
@@ -133,6 +133,7 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) { | |||
result.add(new CryptoCurrency("GRC", "Gridcoin")); | |||
if (!baseCurrencyCode.equals("LTC")) | |||
result.add(new CryptoCurrency("LTC", "Litecoin")); | |||
result.add(new CryptoCurrency("MBYT", "Madbyte")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not touch this file.
@@ -988,6 +988,21 @@ public void testPHR() { | |||
assertFalse(validator.validate("").isValid); | |||
} | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbeams do we want anybody to touch this file anymore?
Instructions for how to list an asset are being changed as we type. Stay tuned for further updates. |
The process for listing an asset has recently changed (see #32), and I am now closing this pull request along with all other outstanding asset listing pull requests. Please read and follow the new instructions at https://bisq.network/list-asset and re-submit a new pull request when ready. Note that Bisq v0.7.0 will likely ship within the next week, so you should still be able to get your asset listed in time for that release. Thanks. |