Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xclim #414

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Update xclim #414

wants to merge 8 commits into from

Conversation

Zeitsperre
Copy link
Collaborator

Overview

This PR fixes [issue id]

Changes:

  • Added ...

Related Issue / Discussion

Additional Information

Links to other issues or sources.

@tlogan2000
Copy link
Collaborator

tlogan2000 commented Oct 29, 2024

Moving forward I will need to use xscen for additions to the climatedata.ca analysis page : I have started a branch https://github.com/bird-house/finch/tree/use_xscen. I suggest we merge the two branches togther as they have more or less the same problems right now. Using xscen requirement list becomes simpler as many of the dependencies are bundled together (xclim, clisops, xesmf). However, changes to xclim are currently breaking the creation of wps processes

@aulemahal
Copy link
Collaborator

@tlogan2000 Indeed, there was a dict-like access on a Parameter object, which lost that feature in recent xclim. However, there is also a bug in xclim.

The indicator "frost_free_spell_max_length" has the default ">=" for its parameter op. But in its docstring, it lists the possible choices for op as <, <=, le, lt... A faulty copy-paste I presume. I added a workaround that spits a log error.

@Zeitsperre
Copy link
Collaborator Author

@aulemahal There's still time to fix this bug upstream before the patch release. I'll see if we can get everything together for a release later today.

@aulemahal
Copy link
Collaborator

Yish. I'll leave you the stats / discharge issues, but cf-xarray's reshape_unique_geometries seems completely broken with the newest xarray...

@tlogan2000
Copy link
Collaborator

@Zeitsperre @aulemahal I am starting to implement changes to the spatial averaging section of the ensembles code (using xscen but with this branch as a starting point). Opinions whether I should push these "xscen" changes in this branch directly?

@Zeitsperre
Copy link
Collaborator Author

@tlogan2000 I would make a branch based off of this work. We don't want to mix up the conversion work with the new features if we can. It's bad enough haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCDP help wanted Extra attention is needed priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants