Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Python version to make it compatible with DSSP #637

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

padix-key
Copy link
Member

Currently the DSSP tests are disabled in next-major-release due to some incompatibility between libboost and DSSP. This PR aims to solve this, by temporarily decreasing the Python version in the environment again.

Having a compatible DSSP software can be tackled later, e.g. by publishing https://github.com/PDB-REDO/dssp in conda-forge, as libboost is only required for testing (PDB-REDO/dssp#50 (comment)):

The requirements are limited, only zlib development files are needed. And boost is only required for building unit-tests.

Having an updated version of DSSP available would also solve #622.

@t0mdavid-m t0mdavid-m self-requested a review August 21, 2024 07:48
Copy link
Member

@t0mdavid-m t0mdavid-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@padix-key padix-key merged commit 0ddfd8f into biotite-dev:next-major-release Aug 21, 2024
21 checks passed
@padix-key padix-key deleted the py-version branch August 22, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants