Remove uses of cloneDeep in qedge2bteedge #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears the actual tests are succeeding, there is some problem with the coverage report causing checks to fail. |
|
@newgene I recommend this for merge / push to prod. ASAP is okay if needed for testing/fixing other issues. I've tried out a few queries and the behavior is as-expected. the performance (speed) seems comparable as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(addresses biothings/biothings_explorer#323)
This PR removes uses of
cloneDeep. Edges which were previously cloned are not used or edited in any way after being converted. Someqedgesare converted to multipleBTEEdgeswith different parameters added in the process, meaning thatnew = { ...original }assignment with references should suffice. Testing several queries, including one and two hop, etc, shows no change in outputs.