-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge/Node constraints #194
base: main
Are you sure you want to change the base?
Conversation
@rjawesome Reviewed&tested and everything looks good. Hoping to get to dev today/monday. Regarding your comment about node constraints possibly behaving weirdly with subclassing, could you explain what ambiguities arise? |
@tokebe ie. if a result contains the edge |
Thanks! I think that'll probably be fine for now, since the majority of things being constrained on would be represented in |
@tokebe This PR should be good to go, with merge conflicts fixed, as well as working properly with subclassing. |
biothings/biothings_explorer#795
Note: for subclass edges, the constraint is applied to the underlying edge. Ie. if a subclass edge represents A--treats-->B--subclass-->C then the constraints are applied to the A->B edge (and A/B nodes).
Example Query: