-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Additional Attributes into an array #105
Conversation
added a comment biothings/biothings_explorer#463 (comment). However, as I note, it may be a separate issue rather than something that can go with this |
@rjawesome I tried copying the code changes, and testing them... when I run the original test query, I do not see the 9 figures' information...instead I see:
I tried only keeping the change c07de55 but I still see the same thing. |
I see the same issue for the MyVariant query; all affected "additional attributes" are empty objects: see edge
|
The queries are working locally on my machine, but I did notice that I was missing an Array.from which I had in my workspace and not in my PR, although that shouldn't have affected the earlier commit? (I do note in my testing removing the Array.from causes the value to be an empty object so that seems to be the most likely culprit) Is there any other differences I could check between my environment and the one you are testing on? |
Replacing this PR with #108 |
This PR is meant to solve this issue. I currently have made all additional attributes to an array, even if they only have one value similar to biolink attributes such as the ones in this screenshot. The behavior could be changed to make single values into normal values rather than single value arrays.