Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pnpm installation link to INSTALLATION.md #755

Closed
wants to merge 1 commit into from
Closed

add pnpm installation link to INSTALLATION.md #755

wants to merge 1 commit into from

Conversation

andrewsu
Copy link
Member

No description provided.

@colleenXu
Copy link
Collaborator

colleenXu commented Oct 25, 2023 •
edited
Loading

@tokebe @andrewsu I think there's an confusing grammar issue here. I think those lines are only about Node.js, not pnpm...

Is this correct?

For development, you will need Node.js and the pnpm package manager installed in your environment.

And then the pnpm install info is a few lines down in https://github.com/biothings/biothings_explorer/blob/4ecd7573f9a1ee7a31234cce71caef79c498f09e/docs/INSTALLATION.md#nodejs-and-pnpm

@tokebe
Copy link
Member

tokebe commented Oct 25, 2023 •
edited
Loading

RE: @colleenXu's response, the link is already included on this line.

@andrewsu
Copy link
Member Author

thanks, I missed it!

@andrewsu andrewsu closed this Oct 25, 2023
@tokebe tokebe deleted the andrewsu-patch-1 branch October 25, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewsu @colleenXu @tokebe