-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qualifiers #535
Add qualifiers #535
Conversation
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 67.54% 67.54%
=======================================
Files 29 29
Lines 687 687
=======================================
Hits 464 464
Misses 223 223 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@tokebe Does this PR need the custom https://github.com/biothings/BioThings_Explorer_TRAPI/blob/dev/src/config/smartapi_overrides.json that's on dev right now? Also, I made PRs for the x-bte annotation. However, I suggest waiting to merge them until all instances are ready to move to qualifiers/biolink3... |
I don't think we need the overrides, as these PR branches are merged into dev, which has the overrides. Once we start deploying to CI/Test/Prod, then we'll want to just update the annotations I think. Unless you mean that should wait until other ARAs and KPs are ready to move this feature to Prod? |
Okay, it sounds like for the overrides...
I think we're waiting to deploy to ci/test/prod until Translator tells us it's okay to do so? |
going to leave it as GO MF
Update broken tests, smartapi spec, hard-cached specs to support qualifiers and biolink 3.1.1
Related PRs: