Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifiers #535

Merged
merged 9 commits into from
Dec 21, 2022
Merged

Add qualifiers #535

merged 9 commits into from
Dec 21, 2022

Conversation

tokebe
Copy link
Member

@tokebe tokebe commented Dec 9, 2022

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #535 (f7da069) into main (a2b807e) will not change coverage.
The diff coverage is n/a.

❗ Current head f7da069 differs from pull request most recent head 88ef978. Consider uploading reports for the commit 88ef978 to get more accurate results

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   67.54%   67.54%           
=======================================
  Files          29       29           
  Lines         687      687           
=======================================
  Hits          464      464           
  Misses        223      223           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@colleenXu
Copy link
Collaborator

colleenXu commented Dec 10, 2022

@tokebe Does this PR need the custom https://github.com/biothings/BioThings_Explorer_TRAPI/blob/dev/src/config/smartapi_overrides.json that's on dev right now?

Also, I made PRs for the x-bte annotation. However, I suggest waiting to merge them until all instances are ready to move to qualifiers/biolink3...

@tokebe
Copy link
Member Author

tokebe commented Dec 12, 2022

I don't think we need the overrides, as these PR branches are merged into dev, which has the overrides. Once we start deploying to CI/Test/Prod, then we'll want to just update the annotations I think. Unless you mean that should wait until other ARAs and KPs are ready to move this feature to Prod?

@colleenXu
Copy link
Collaborator

@tokebe

Okay, it sounds like for the overrides...

  • we'll have to be careful merging to dev, since we'll want to keep the overrides currently in dev
  • we plan to deploy to ci/test/prod instances all at once, so around that time, we'll merge the PRs for the registry and refresh the registry.

I think we're waiting to deploy to ci/test/prod until Translator tells us it's okay to do so?

@colleenXu
Copy link
Collaborator

colleenXu commented Dec 14, 2022

Addresses #512 and #514

@tokebe tokebe merged commit 1f3f71b into main Dec 21, 2022
@tokebe tokebe deleted the add-qualifiers branch October 25, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants